515642 – multilib-build.eclass - MULTILIB_COMPAT corner-case breakage

Bug 515642 - multilib-build.eclass - MULTILIB_COMPAT corner-case breakage

Summary: multilib-build.eclass - MULTILIB_COMPAT corner-case breakage

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Multilib team

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2014-06-29 02:54 UTC by Greg Turner
Modified:	2014-06-29 07:53 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
dont_crash.patch (dont_crash.patch,1.22 KB, patch) 2014-06-29 02:54 UTC, Greg Turner	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Greg Turner 2014-06-29 02:54:22 UTC

Created attachment 379876 [details, diff]
dont_crash.patch

This is, I guess, sort-of a bug waiting to happen although perhaps it's not affecting end-users yet.  I keep a triple-multilib system, specifically so I can spot bugs like this one.

I bumped into this emerging =media-gfx/nvidia-cg-toolkit-3.1.0013-r3.  The problem manifested as a crash in multilib_get_enabled_abi_pairs, "abi_x86_x32 not in IUSE" -- well, indeed it wasn't, due to that ebuild employing MULTILIB_COMPAT.

Obvious solution is enclosed as a patch: use use_if_iuse instead of use.

Comment 1 Michał Górny archtester

2014-06-29 07:47:58 UTC

You are indeed correct. Though Ciaran considers use_if_iuse an aberration, so I'll check MULTILIB_COMPAT instead.

Comment 2 Michał Górny archtester

2014-06-29 07:53:55 UTC

+  29 Jun 2014; Michał Górny <mgorny@gentoo.org> multilib-build.eclass:
+  Check MULTILIB_COMPAT before querying USE flags. Bug #515642, thanks to Greg
+  Turner.

Also, you've got a typo in your Signed-off-by.