Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 515598 - www-client/chromium should determine pepper flash version programmatically
Summary: www-client/chromium should determine pepper flash version programmatically
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Chromium Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-28 13:40 UTC by Lorenz
Modified: 2014-06-28 13:52 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lorenz 2014-06-28 13:40:01 UTC
Instead of hardcoding --ppapi-flash-version, it should be determined from pepper flash's manifest.json, which contains a field "version".

One way to do this would be to set the version as follows:
--ppapi-flash-version=$(grep '"version":' /usr/lib64/chromium-browser/PepperFlash/manifest.json| grep -Po '(?<=version": ")(?:\d|\.)*')

Of course, you (c|sh)ould rewrite this to work without the pcre USE flag on grep (use sed?), and probably substitute the chromium installation path suitably. This is just what I do on my system.

Reproducible: Always
Comment 1 Lorenz 2014-06-28 13:40:42 UTC
Obviously I am too stupid to type, should be www-client/chromium.
Comment 2 Mike Gilbert gentoo-dev 2014-06-28 13:52:20 UTC
Err... have a look at src_install in the chrome-binary-plugins ebuild.

There's no reason to recompute that every time we start chromium.