Bug 51496 – src_unpack() and scr_compile() are wrong in mldonkey ebuilds

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Laurento Frittella (mrfree) 2004-05-19 11:35:11 UTC]

In the ebuild (mldonket-2.5.21 and others) in the function src_compile() the "make depend" command need to be executed AFTER econf; and in src_unpack() accordingly with spiralvoice ( http://8ung.at/spiralvoice/ ) instructions, some command need to be added

This is IMHO the correct sequence:

src_unpack() {
        unpack ${P}.tar.gz
 
        cd ${S}
        epatch ${FILESDIR}/${P}-configure.patch
        #Don't change this, unless you know what you are doing
        patch -p0 -E < ${DISTDIR}/patch_pack21d || die
        cd config; autoconf; cd ..
 
}
src_compile() {
        use gtk || export GTK_CONFIG="no"
 
        # the dirs are not (yet) used, but it doesn't hurt to specify them anyway
        econf \
                --sysconfdir=/etc/mldonkey \
                --sharedstatedir=/var/mldonkey \
                --localstatedir=/var/mldonkey \
                --enable-batch \
                --enable-checks \
                --enable-pthread || die
        make depend
                                                                                
        emake || die
}


Reproducible: Always
Steps to Reproduce:
1.
2.
3.



Expected Results:  
no errors ;)

[Comment 1 Jon Hood (RETIRED) 2004-05-21 11:05:11 UTC]

mldonkey-2.5.21 and 2.5.21-r1 now use this; thank you :)