Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 51373 - albumart-1.3.1.ebuild (New Package)
Summary: albumart-1.3.1.ebuild (New Package)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Jon Hood (RETIRED)
URL: http://louhi.kempele.fi/~skyostil/pro...
Whiteboard:
Keywords: EBUILD
: 55654 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-05-18 03:53 UTC by Joonas Kerttula
Modified: 2004-07-14 16:14 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
albumart-1.3.ebuild (albumart-1.3.ebuild,648 bytes, text/plain)
2004-05-18 03:57 UTC, Joonas Kerttula
Details
albumart-1.3.1.ebuild (albumart-1.3.1.ebuild,750 bytes, text/plain)
2004-06-28 07:31 UTC, Joonas Kerttula
Details
CHANGELOG (CHANGELOG,1.23 KB, text/plain)
2004-06-28 07:36 UTC, Joonas Kerttula
Details
albumart-1.3.1.ebuild (albumart-1.3.1.ebuild,541 bytes, application/octet-stream)
2004-07-10 18:22 UTC, Joonas Kerttula
Details
albumart-1.3.1.ebuild (albumart-1.3.1.ebuild,549 bytes, text/plain)
2004-07-10 18:52 UTC, Joonas Kerttula
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Kerttula 2004-05-18 03:53:44 UTC
Hi!

Please add this new great program to the portage tree.
I think media-sound category would be right place for it, i am not sure.

There's a little description:

Please look at the program homepage or read the text: http://louhi.kempele.fi/~skyostil/projects/albumart/

Albumart a program that will semi-automatically download album cover images for your music collection. All you have to do is point it at the root of your music directory and for each directory, the program will download a set of corresponding (well, best guess) album covers from the Internet, from which you can choose one that suits your fancy.

ability to save images into ID3 v2 tags

Currently supported image providers:
Amazon.com
Comment 1 Joonas Kerttula 2004-05-18 03:57:31 UTC
Created attachment 31643 [details]
albumart-1.3.ebuild
Comment 2 Joonas Kerttula 2004-06-28 07:31:30 UTC
Created attachment 34330 [details]
albumart-1.3.1.ebuild
Comment 3 Joonas Kerttula 2004-06-28 07:33:42 UTC
http://louhi.kempele.fi/~skyostil/projects/albumart/
Comment 4 Joonas Kerttula 2004-06-28 07:36:07 UTC
Created attachment 34331 [details]
CHANGELOG

Changelog for albumart
Comment 5 Massimiliano Torromeo 2004-07-02 08:18:01 UTC
*** Bug 55654 has been marked as a duplicate of this bug. ***
Comment 6 Jon Hood (RETIRED) gentoo-dev 2004-07-02 08:39:18 UTC
Reposting from the dup bug:

Ok, a few things before we can even consider this package:
* please put the correct header into the ebuild from /usr/portage/header.txt without modifying it (since you are Joonas, I assume we have permission to include this). You will get proper credit in the ChangeLog, but the Gentoo Foundation needs the header of the ebuild.
** S=${WORKDIR}/${P} is redundantly redundant
** IUSE="" is missing
** SLOT="0" is missing
* All packages are required to spend at least 30 days in ~arch testing, meaning that KEYWORDS="x86...." should probably be changed to KEYWORDS="~x86" and let the arch maintainers sort out what other architectures this should work on (unless you have gotten it to work on another arch already?)
* src_compile() will try to do some things, even though there is nothing to configure nor compile. A dummy src_compile() { einfo "nothing to compile" } or something like that would be best to use.
* I cannot find a COPYING or LICENSE file in the package- how do you know it's under the GPL-2? (since you made the ebuild, I assume you put it under the GPL, but it does need to be explicitly stated somewhere by the author, even if it's here in bugzilla)

double asterisks means take a look at http://www.gentoo.org/doc/en/ebuild-mistakes.xml

I know I nitpicked on this ebuild, and these were just little, common mistakes- nothing big. The main thing is that we need to verify this is under the GPL. The other things are ebuild policy that would be good to learn, so when you submit more ebuilds in the future, it's less work for the devs to do ;).
Comment 7 Jon Hood (RETIRED) gentoo-dev 2004-07-02 22:01:34 UTC
And the site is now giving me a 404 error... Joonas, could you please comment on at least the license and where the website is?
Comment 8 Jon Hood (RETIRED) gentoo-dev 2004-07-06 16:10:01 UTC
I tried to catch up with Joonas and/or the person who runs the albumart website on IRC but was promptly cursed out and banned from the channels for asking if they were the albumart maintainers. I then got PMs from members of the channel that were very rude and profane. As no one has commented on the license of this package and because of rudeness on IRC, I am closing this request until the author of the ebuild can make the requested changes and comment on the license. Please reopen when such changes are made.
Comment 9 Joonas Kerttula 2004-07-10 18:22:54 UTC
Created attachment 35138 [details]
albumart-1.3.1.ebuild

Problems that you noticed are now fixed!

Albumart is under GPL-2 license because it is said in all .py files like this:
"""
Copyright (C) 2003 Sami Ky
Comment 10 Joonas Kerttula 2004-07-10 18:22:54 UTC
Created attachment 35138 [details]
albumart-1.3.1.ebuild

Problems that you noticed are now fixed!

Albumart is under GPL-2 license because it is said in all .py files like this:
"""
Copyright (C) 2003 Sami Kyöstilä <skyostil@kempele.fi>

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
at your option) any later version.
"""

I talked to the programmer of the Albumart and he said that he will add LICENSE
file to the next release. Next release will come as soon as he add few missed
features. But as you can see this same ebuild can be found from his homepage.
Actually he personally asked me to put this ebuild to portage after so many
requests.

Sadly I was on holiday trip and I was not able to read my mail earlier. Sorry
about that. Programmer was unavailable also at that time. Use ICQ (174889519)
or e-mail <skyostil@NOSPAM.kempele.fi> to contact to the programmer.

Hopefully there are no more mistakes and albumart can continue its great
journey.
Comment 11 Joonas Kerttula 2004-07-10 18:24:14 UTC
Problems fixed... I'm really sorry about the delay. Let's reopen this bug
Comment 12 Joonas Kerttula 2004-07-10 18:26:01 UTC
Problems fixed... I'm really sorry about the delay.
Comment 13 Joonas Kerttula 2004-07-10 18:52:13 UTC
Created attachment 35139 [details]
albumart-1.3.1.ebuild

fixed few typo
Comment 14 Jon Hood (RETIRED) gentoo-dev 2004-07-14 16:14:13 UTC
now in portage, thanks for the submission :).