512650 – media-video/vlc: pkg_setup() body should be wrapped around MERGE_TYPE

Bug 512650 - media-video/vlc: pkg_setup() body should be wrapped around MERGE_TYPE

Summary: media-video/vlc: pkg_setup() body should be wrapped around MERGE_TYPE

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Paweł Stankowski

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2014-06-07 14:07 UTC by Fabio Erculiani (RETIRED)
Modified:	2014-11-10 08:48 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Fabio Erculiani (RETIRED) gentoo-dev

2014-06-07 14:07:27 UTC

The current pkg_setup is:

pkg_setup() {
	if [[ "$(tc-getCC)" == *"gcc"* ]] ; then
		if [[ $(gcc-major-version) < 4 || ( $(gcc-major-version) == 4 && $(gcc-minor-version) < 5 ) ]] ; then
			die "You need to have at least >=sys-devel/gcc-4.5 to build and/or have a working vlc, see bug #426754."
		fi
	fi
}

However, this is a build related check and should be wrapped around "${MERGE_TYPE}" != "binary" for proper binpkgs support.
On Sabayon, we don't ship with any gcc compiler by default.

Comment 1 Yixun Lan archtester

2014-11-10 08:48:37 UTC

fixed in tree, please reopen if you still have problem.


@@ -195,7 +195,7 @@ REQUIRED_USE="
 S="${WORKDIR}/${MY_P}"
 
 pkg_setup() {
-       if [[ "$(tc-getCC)" == *"gcc"* ]] ; then
+       if [[ "${MERGE_TYPE}" != "binary" && "$(tc-getCC)" == *"gcc"* ]] ; then
                if [[ $(gcc-major-version) < 4 || ( $(gcc-major-version) == 4 && $(gcc-minor-version) < 5 ) ]] ; then