Bug 512630 – =media-libs/cogl-1.18.0 - In file included from ./cogl-matrix.c:76:0: ./cogl.h:35:2: error: #error "<cogl/cogl.h> shouldn't be included internally"

• Status: RESOLVED TEST-REQUEST
• Product: Gentoo Linux

[Description Greg Turner 2014-06-07 01:16:26 UTC]

Created attachment 378406 [details, diff]
cogl-1.18.0-cogl-h-trouble.patch

Fails for me compiling cogl/cogl-matrix.c:

/bin/sh ../libtool  --tag=CC   --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I..  -I.. -I.. -I./deprecated -I./winsys -I./driver/gl -I./driver/gl/gl -I./driver/gl/gles  -DG_LOG_DOMAIN=\"Cogl\" -DCOGL_COMPILATION -DCOGL_GL_LIBNAME=\"libGL.so.1\" -DCOGL_GLES1_LIBNAME=\"\" -DCOGL_GLES2_LIBNAME=\"\" -DCOGL_LOCALEDIR=\""/usr/share/locale"\"    -pthread -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -DG_DISABLE_CHECKS -DG_DISABLE_CAST_CHECKS    -O2 -pipe -g -mtune=native -march=native -c -o cogl-matrix.lo `test -f './cogl-matrix.c' || echo './'`./cogl-matrix.c
libtool: compile:  x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I.. -I./deprecated -I./winsys -I./driver/gl -I./driver/gl/gl -I./driver/gl/gles -DG_LOG_DOMAIN=\"Cogl\" -DCOGL_COMPILATION -DCOGL_GL_LIBNAME=\"libGL.so.1\" -DCOGL_GLES1_LIBNAME=\"\" -DCOGL_GLES2_LIBNAME=\"\" -DCOGL_LOCALEDIR=\"/usr/share/locale\" -pthread -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DG_DISABLE_CHECKS -DG_DISABLE_CAST_CHECKS -O2 -pipe -g -mtune=native -march=native -c ./cogl-matrix.c  -fPIC -DPIC -o .libs/cogl-matrix.o
In file included from ./cogl-matrix.c:76:0:
./cogl.h:35:2: error: #error "<cogl/cogl.h> shouldn't be included internally"
 #error "<cogl/cogl.h> shouldn't be included internally"
  ^
Makefile:1989: recipe for target 'cogl-matrix.lo' failed
make[4]: *** [cogl-matrix.lo] Error 1
make[4]: Leaving directory '/var/tmp/portage/media-libs/cogl-1.18.0/work/cogl-1.18.0/cogl'

Not sure what's going on as I don't see anybody else with this problem.  But the enclosed patch fixed it for me.  A quick search suggests that upstream, all such references to cogl.h have been removed as superfluous, so hopefully this is safe.

[Comment 1 Pacho Ramos 2014-06-09 08:55:59 UTC]

I cannot reproduce the issue, please report this to upstream to confirm the patch is really ok -> bugzilla.gnome.org

[Comment 2 Ed Catmur 2014-06-11 00:17:29 UTC]

Probably result of patch for Bug 483332.  I'll look into it.

[Comment 3 Pacho Ramos 2015-06-14 13:33:54 UTC]

Please also try with 1.20.0 (builds fine here too)