Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 512366 - x11-misc/xscreensaver-5.27: .desktop file broken by invalid `cp driver/screensaver-properties.desktop{.in,}` in the ebuild
Summary: x11-misc/xscreensaver-5.27: .desktop file broken by invalid `cp driver/screen...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Desktop Misc. Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-04 10:19 UTC by Ilya Gordeev
Modified: 2014-06-04 17:06 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Gordeev 2014-06-04 10:19:05 UTC 
QA Notice: This package installs one or more .desktop files that do not
pass validation.

        /usr/share/applications/xscreensaver-properties.desktop: error: file contains key "_Comment" in group "Desktop Entry", but key names must contain only the characters A-Za-z0-9- (they may have a "[LOCALE]" postfix)
        /usr/share/applications/xscreensaver-properties.desktop: error: file contains key "_Name" in group "Desktop Entry", but key names must contain only the characters A-Za-z0-9- (they may have a "[LOCALE]" postfix)
        /usr/share/applications/xscreensaver-properties.desktop: error: required key "Name" in group "Desktop Entry" is not present

Reproducible: Always
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2014-06-04 11:32:12 UTC 
Looks like someone broke the ebuild by adding a line like this:

cp driver/screensaver-properties.desktop{.in,} || die

That's bogus, as the file is generated from .in, and should not be copied directly
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2014-06-04 11:51:41 UTC 
Yes.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2014-06-04 12:24:59 UTC 
Should be fixed now. Please test.
Comment 4 Agostino Sarubbo gentoo-dev 2014-06-04 13:35:31 UTC 
Please also block the tracker.
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2014-06-04 17:06:29 UTC 
Wrong. It failed validation because of what I did, not because of what's coming down from upstream.