Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 511986 - <sci-electronics/oregano-0.83.1 - In file included from ../../src/netlist-editor.c:35:0: /usr/include/gtksourceview-3.0/gtksourceview/gtksourcelanguagemanager.h:42:2: error: unknown type name ‘GObjec
Summary: <sci-electronics/oregano-0.83.1 - In file included from ../../src/netlist-edi...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: The Soldering-Iron Brotherhood
URL:
Whiteboard:
Keywords:
Depends on: 667142
Blocks: 644336
  Show dependency tree
 
Reported: 2014-05-31 21:10 UTC by Kobboi
Modified: 2020-01-14 16:23 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fixes cherry picked from aforementioned github link (oregano-0.82-gtksourceview-fixes.patch,975 bytes, patch)
2014-10-29 12:32 UTC, David Flogeras
Details | Diff
oregano-0.83.1.ebuild (oregano-0.83.1.ebuild,1.47 KB, text/plain)
2014-11-14 21:40 UTC, Sławek Lis (RETIRED)
Details
oregano-0.83.1.1.ebuild (oregano-0.83.1.1.ebuild,1.31 KB, text/plain)
2014-11-17 08:15 UTC, Sławek Lis (RETIRED)
Details
oregano fix gtk (oregano-0.83.1.1-gtk-mine.patch,1.12 KB, patch)
2014-11-24 10:44 UTC, Yixun Lan
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kobboi 2014-05-31 21:10:42 UTC
In file included from netlist-editor.c:33:0:
/usr/include/gtksourceview-3.0/gtksourceview/gtksourcelanguagemanager.h:42:2: error: unknown type name ‘GObject’
  GObject parent_instance;
  ^
/usr/include/gtksourceview-3.0/gtksourceview/gtksourcelanguagemanager.h:49:2: error: unknown type name ‘GObjectClass’
  GObjectClass parent_class;
  ^
/usr/include/gtksourceview-3.0/gtksourceview/gtksourcelanguagemanager.h:59:1: error: unknown type name ‘GType’
 GType     gtk_source_language_manager_get_type   (void) G_GNUC_CONST;
 ^


Reproducible: Always
Comment 1 Kobboi 2014-05-31 21:12:39 UTC
https://github.com/drahnr/oregano/issues/67

They fixed it in oregano-0.83.1, so maybe it's a good time to upstep
Comment 2 David Flogeras 2014-10-29 12:32:19 UTC
Created attachment 387722 [details, diff]
fixes cherry picked from aforementioned github link

Here's a patch to make 0.82 build against current gtk/gtksourceview.  I looked into upgrading to 0.83.1, but it seems that upstream has changed hands, and the new maintainer moved to waf as a build system and migrating the ebuild is beyond me at the moment.  Here's a stopgap in the meantime so that we can have a version of oregano that builds.
Comment 3 Sławek Lis (RETIRED) gentoo-dev 2014-11-14 21:40:38 UTC
Created attachment 389334 [details]
oregano-0.83.1.ebuild
Comment 4 Sławek Lis (RETIRED) gentoo-dev 2014-11-14 21:43:22 UTC
Can you please check attached ebuild?
I'm not familiar with waf, but as far as I can understand, the 'waf' is not included in packaged file. If someone can hint another idea to solve this, I would hapilly do. In other case - I may use this ebuild to update portage.
Comment 5 Yixun Lan archtester gentoo-dev 2014-11-14 23:21:25 UTC
>SRC_URI="https://github.com/drahnr/${PN}/tarball/${PV} -> ${P}.tar.gz >http://dev.gentoo.org/~slis/oregano/waf-1.7.15 -> waf"

I'm not familiar with waf-utils eclass (so CC @gnome team), and not sure if adding your own specific waf is necessary. there is one "wscript" file in the source, but "waf" is missing. check the git repo, the file waf do exist,  https://github.com/drahnr/oregano/blob/master/waf

I've a ebuild for oregano-9999, but other problem hit. build fail at src_compile() using the waf-utils eclass, probably another issue.
Comment 6 Yixun Lan archtester gentoo-dev 2014-11-14 23:29:11 UTC
i've got this while using "repoman full"

   sci-electronics/oregano/oregano-0.83.1-r1.ebuild: Ebuild contains leading spaces on line: 19
   sci-electronics/oregano/oregano-0.83.1-r1.ebuild: Ebuild contains leading spaces on line: 20
   sci-electronics/oregano/oregano-0.83.1-r1.ebuild: Ebuild contains leading spaces on line: 21
   sci-electronics/oregano/oregano-0.83.1-r1.ebuild: Ebuild contains leading spaces on line: 22
   sci-electronics/oregano/oregano-0.83.1-r1.ebuild: Ebuild contains leading spaces on line: 24
   sci-electronics/oregano/oregano-0.83.1-r1.ebuild: Ebuild contains leading spaces on line: 26
   sci-electronics/oregano/oregano-0.83.1-r1.ebuild: Ebuild contains leading spaces on line: 27
   sci-electronics/oregano/oregano-0.83.1-r1.ebuild: Ebuild contains leading spaces on line: 32
   sci-electronics/oregano/oregano-0.83.1-r1.ebuild: Ebuild contains leading spaces on line: 33
   sci-electronics/oregano/oregano-0.83.1-r1.ebuild: Ebuild contains leading spaces on line: 37
   sci-electronics/oregano/oregano-0.83.1-r1.ebuild: Ebuild contains leading spaces on line: 41
   sci-electronics/oregano/oregano-0.83.1-r1.ebuild: Ebuild contains leading spaces on line: 42
   sci-electronics/oregano/oregano-0.83.1-r1.ebuild: Ebuild contains leading spaces on line: 43
   sci-electronics/oregano/oregano-0.83.1-r1.ebuild: Ebuild contains leading spaces on line: 44
   sci-electronics/oregano/oregano-0.83.1-r1.ebuild: Ebuild contains leading spaces on line: 45
   sci-electronics/oregano/oregano-0.83.1-r1.ebuild: Ebuild contains leading spaces on line: 46
   sci-electronics/oregano/oregano-0.83.1-r1.ebuild: Ebuild contains leading spaces on line: 50
  ebuild.notadded               3
   sci-electronics/oregano/oregano-0.83.1.ebuild
   sci-electronics/oregano/oregano-0.83.1-r1.ebuild
   sci-electronics/oregano/oregano-9999.ebuild
  inherit.unused                3
   sci-electronics/oregano/oregano-0.83.1.ebuild: no function called from autotools.eclass; please drop
   sci-electronics/oregano/oregano-0.83.1-r1.ebuild: no function called from autotools.eclass; please drop
Comment 7 Sławek Lis (RETIRED) gentoo-dev 2014-11-15 07:06:34 UTC
(In reply to Yixun Lan from comment #5)
> >SRC_URI="https://github.com/drahnr/${PN}/tarball/${PV} -> ${P}.tar.gz >http://dev.gentoo.org/~slis/oregano/waf-1.7.15 -> waf"
> 
> I'm not familiar with waf-utils eclass (so CC @gnome team), and not sure if
> adding your own specific waf is necessary. there is one "wscript" file in
> the source, but "waf" is missing. check the git repo, the file waf do exist,
> https://github.com/drahnr/oregano/blob/master/waf
> 
> I've a ebuild for oregano-9999, but other problem hit. build fail at
> src_compile() using the waf-utils eclass, probably another issue.


I haven't added my specific waf, but the one from github. It's not included in distfile (why?). Maybe some other hits how to do this another way?

I'll see what can I do for the other build errors.
Comment 8 Yixun Lan archtester gentoo-dev 2014-11-15 15:31:29 UTC
(In reply to Sławek Lis from comment #7) 
> I haven't added my specific waf, but the one from github. It's not included
> in distfile (why?). Maybe some other hits how to do this another way?
maybe upstream release v0.83.1 too early, I've checked git repo, waf file was added after 0.83.1. It seems more sensible to me to wait for another version, or ask if he willing to just release 0.83.2.

but if you insist to push this version, then I wouldn't mind, just go ahead ;-)

> 
> I'll see what can I do for the other build errors.
I've noticed that you may not copy the ebuild from version 0.82, and do the change based on it. personally I'd strongly encourage to do that, I'm always checking the changes by "diff -Nur old-0.82.ebuild new-0.83.1.ebuild", and introducing cosmetic changes make me hard to review.

>SRC_URI="https://github.com/drahnr/${PN}/tarball/${PV} -> ${P}.tar.gz http://dev.gentoo.org/~slis/oregano/waf-1.7.15 -> waf"

you could change tarball to this [1], it's more official release, check https://github.com/drahnr/oregano/releases, and later you can drop following line
>S="${WORKDIR}/drahnr-oregano-4460753/"

>src_prepare() {
>        cp "${DISTDIR}/waf" "${S}"
>        chmod +x "${S}/waf"
strictly, you should add "|| die" to those two above

you drop "ppc" keyword, better have good reason? unsatisfied dependency?

[1]"https://github.com/drahnr/oregano/archive/v${PV}.tar.gz -> ${P}.tar.gz"
Comment 9 Sławek Lis (RETIRED) gentoo-dev 2014-11-15 20:17:37 UTC
Thanks for your hints! They're all very useful.

(In reply to Yixun Lan from comment #8)
> (In reply to Sławek Lis from comment #7) 
> > I haven't added my specific waf, but the one from github. It's not included
> > in distfile (why?). Maybe some other hits how to do this another way?
> maybe upstream release v0.83.1 too early, I've checked git repo, waf file
> was added after 0.83.1. It seems more sensible to me to wait for another
> version, or ask if he willing to just release 0.83.2.

That's what I though. I don't want to force push anything, I just saw that people are using this package and it looks abandoned.

> but if you insist to push this version, then I wouldn't mind, just go ahead
> ;-)

I get what I want - someone is interested and gave me ideas. I was confused mostly about this 'waf' binary part. Personally, I haven't seen anything like that before (downloading waf in ebuild).



> >SRC_URI="https://github.com/drahnr/${PN}/tarball/${PV} -> ${P}.tar.gz http://dev.gentoo.org/~slis/oregano/waf-1.7.15 -> waf"
> 
> you could change tarball to this [1], it's more official release, check
> https://github.com/drahnr/oregano/releases, and later you can drop following
> line
> >S="${WORKDIR}/drahnr-oregano-4460753/"

That's what I was looking for. Thanks.


> >src_prepare() {
> >        cp "${DISTDIR}/waf" "${S}"
> >        chmod +x "${S}/waf"
> strictly, you should add "|| die" to those two above

Sure.

> you drop "ppc" keyword, better have good reason? unsatisfied dependency?

It's quite big source change, and I don't have access to any ppc machine I could test this on.
Comment 10 Yixun Lan archtester gentoo-dev 2014-11-16 11:03:40 UTC
hi @slis, can you try version 0.83.1.1? thanks
I've got response from upstream.

-- quote --
A similar issue arose in ArchLinux thus I cherry-pick'd the commit into a stable branch stable-v0.83.1 tagged v0.83.1.1.

A version 0.83.2 will be released as soon as #128, #127 and especially #130 are all fixed, but since those are kind of tricky to fix properly, this might still take another month or two.
Comment 11 Sławek Lis (RETIRED) gentoo-dev 2014-11-17 08:14:55 UTC
I've updated ebuild. It builds and installs fine for me, except that there are some Access denied errors during installation phase. I'll check them later, meanwhile can you check if it works for you? Thanks!
Comment 12 Sławek Lis (RETIRED) gentoo-dev 2014-11-17 08:15:28 UTC
Created attachment 389558 [details]
oregano-0.83.1.1.ebuild
Comment 13 Yixun Lan archtester gentoo-dev 2014-11-19 07:06:35 UTC
same problem here, haven't really got time to look at it, but I suspect it's the oregano's build script issue.
Comment 14 Sławek Lis (RETIRED) gentoo-dev 2014-11-20 08:38:06 UTC
Can you please post a fail log? I'm unable to reproduce this on my.
Comment 15 Yixun Lan archtester gentoo-dev 2014-11-20 09:49:53 UTC
sorry, I mean same "Access denied errors" here
Comment 16 Yixun Lan archtester gentoo-dev 2014-11-24 10:44:55 UTC
Created attachment 390184 [details, diff]
oregano fix gtk

the proposal patch(data/wscript) would remove "update-mime-database, update-desktop-database" in the install phase, which should fix file access violation problem, doing it instead at fdo-mime_desktop_database_update()

patch for gschema part (wscript), it seems waf auto magically doing " glib-compile-schemas" which cause file access violation[1]. remove it do fix the problem but file /usr/share/glib-2.0/schemas/apps.oregano.gschema.xml will not installed, how about fix it by manually install it? any idea here? I'm not @gnome guru...


[1] file access violation
Failed to create file '/usr/share/glib-2.0/schemas/gschemas.compiled.9L6VPX': Permission denied
'install' finished successfully (19.071s)
>>> Completed installing oregano-0.83.1.1-r1 into /var/tmp/portage/sci-electronics/oregano-0.83.1.1-r1/image/

 * --------------------------- ACCESS VIOLATION SUMMARY ---------------------------
 * LOG FILE: "/var/log/sandbox/sandbox-9492.log"
 * 
VERSION 1.0
FORMAT: F - Function called
FORMAT: S - Access Status
FORMAT: P - Path as passed to function
FORMAT: A - Absolute Path (not canonical)
FORMAT: R - Canonical Path
FORMAT: C - Command Line

F: open_wr
S: deny
P: /usr/share/glib-2.0/schemas/gschemas.compiled.9L6VPX
A: /usr/share/glib-2.0/schemas/gschemas.compiled.9L6VPX
R: /usr/share/glib-2.0/schemas/gschemas.compiled.9L6VPX
C: /usr/bin/glib-compile-schemas /usr/share/glib-2.0/schemas 
 * --------------------------------------------------------------------------------
!!! <oregano-0.83.1.1-r1> Compile Fail: store temp directory
Comment 17 Yixun Lan archtester gentoo-dev 2014-11-24 10:53:10 UTC
btw, this one line at wsscript, but it seems enabled by default, don't know how to disable it. (tried but failed)


        ctx.add_option('--gnomelike', action='store_true', default=True, help='Determines if gnome shemas and gno  me iconcache should be installed')
Comment 18 Gilles Dartiguelongue (RETIRED) gentoo-dev 2014-12-27 16:52:43 UTC
waf should not try to update cache files on its own. In autotools based packages, files can be installed while skipping the cache updates step. This is usually controlled by a --disable-updatedb-mime configure switch. Same for gschemas.

Currently the gschemas.compiled file is not protected but I intend to make it owned by glib ebuild so that unintended overwrite by other ebuilds can be avoided.

Icon, MIME and .desktop caches is a different story but will follow the same path ultimately.
Comment 19 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-01-14 16:23:34 UTC
Package removed.