Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 511930 - app-i18n/atokx3: improve multilib support
Summary: app-i18n/atokx3: improve multilib support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: CJK Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-31 07:59 UTC by Michał Górny
Modified: 2017-08-14 14:19 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
atokx3-3.0.0-r10.ebuild.patch (atokx3-3.0.0-r10.ebuild.patch,3.87 KB, patch)
2014-06-11 23:01 UTC, Andrew Church
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-05-31 07:59:11 UTC
This ebuilds looks like a candidate for multilib-minimal or multilib-build with MULTILIB_COMPAT=( abi_x86_{32,64} ). I'd be happy to help you mangling it except that it seems to require some fancy CD to install.

A few points though:

1. use EAPI=5, and update all the [abi_x86_32] to [abi_x86_32(-)],

2. the eclass will give you abi_x86_{32,64} instead of USE=multilib,

3. if you use multilib-minimal, then you'll want to change that src_prepare() into multilib_src_configure() that mangles stuff for each separatedly, and multilib_src_install(),

4. if you use multilib-build, you can do somewhat close to what you do now, though you should make it more conditional to USE=abi_x86_* than USE=amd64,

5. and you likely want: multilib_foreach_abi gnome2_query_immodules_gtk2
Comment 1 Andrew Church 2014-06-11 23:01:24 UTC
Created attachment 378728 [details, diff]
atokx3-3.0.0-r10.ebuild.patch

Here's a first attempt using multilib-build -- I haven't tried this with x86 but it seems to do the right thing on amd64 (at least, the package contents are the same as before and the program works as expected).  Does this look correct?

I have the CD so I can test any changes (well, when I get back from vacation ;)
Comment 2 Akinori Hattori gentoo-dev 2017-08-14 14:19:21 UTC
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e80fea5b9f61492e9f7ba0a620c07f2f9f892e78

Thank you for the patch!