Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 511876 - net-wireless/broadcom-sta-6.30.223.141-r1 fails due one or more missing patch files
Summary: net-wireless/broadcom-sta-6.30.223.141-r1 fails due one or more missing patch...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sven Vermeulen (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-30 16:56 UTC by faminebadger
Modified: 2014-06-02 19:58 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (build.log,2.35 KB, text/x-log)
2014-05-30 16:56 UTC, faminebadger
Details
emerge --info output (info.out,5.16 KB, text/plain)
2014-05-30 16:57 UTC, faminebadger
Details
Modified broadcom-sta-6.30.223.141-r1.ebuild to revert changes to epatch. (broadcom-sta-6.30.223.141-r1.ebuild,2.79 KB, text/plain)
2014-05-31 19:33 UTC, Eric Siskonen
Details
broadcom-sta-6.30.223.141-linux-3.10.0.patch (broadcom-sta-6.30.223.141-linux-3.10.0.patch,2.85 KB, patch)
2014-06-01 23:13 UTC, M. B.
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description faminebadger 2014-05-30 16:56:00 UTC
Created attachment 377862 [details]
Build log

Attempted to do a world update tonight, and net-wireless/broadcom-sta-6.30.223.141-r1 failed to build due to a missing patch file:

>>> Preparing source in /var/tmp/portage/net-wireless/broadcom-sta-6.30.223.141-r1/work ...
 * Applying broadcom-sta-6.30.223.141-makefile.patch ...
 [ ok ]

 * Cannot find $EPATCH_SOURCE!  Value for $EPATCH_SOURCE is:
 * 
 *   /usr/portage/net-wireless/broadcom-sta/files/broadcom-sta-6.30.223.141-linux-3.10.0.patch
 *   ( broadcom-sta-6.30.223.141-linux-3.10.0.patch )

 * ERROR: net-wireless/broadcom-sta-6.30.223.141-r1::gentoo failed (prepare phase):
 *   Cannot find $EPATCH_SOURCE!

Full logs and emerge --info attached.
Comment 1 faminebadger 2014-05-30 16:57:49 UTC
Created attachment 377864 [details]
emerge --info output
Comment 2 faminebadger 2014-05-30 16:58:53 UTC
gentoo ~ (0) # emerge -pqv '=net-wireless/broadcom-sta-6.30.223.141-r1::gentoo'
[ebuild     U ] net-wireless/broadcom-sta-6.30.223.141-r1 [6.30.223.141]
gentoo ~ (0) #
Comment 3 faminebadger 2014-05-30 16:59:42 UTC
Quick sanity check - indeed it doesn't exist:

gentoo ~ (0) # ls /usr/portage/net-wireless/broadcom-sta/files/broadcom-sta-6.30.223.141-linux-3.10.0.patch
ls: cannot access /usr/portage/net-wireless/broadcom-sta/files/broadcom-sta-6.30.223.141-linux-3.10.0.patch: No such file or directory
gentoo ~ (2) # ls /usr/portage/net-wireless/broadcom-sta/files/
broadcom-sta-5.100.82.111-linux-3.0.patch                 broadcom-sta-5.10.91.9-license.patch
broadcom-sta-5.100.82.112-linux-2.6.39.patch              broadcom-sta-6.30.223.141-eth-to-wlan.patch
broadcom-sta-5.100.82.112-linux-3.2-with-multicast.patch  broadcom-sta-6.30.223.141-gcc.patch
broadcom-sta-5.100.82.112-linux-3.4.patch                 broadcom-sta-6.30.223.141-license.patch
broadcom-sta-5.100.82.112-linux-3.6.patch                 broadcom-sta-6.30.223.141-linux-recent.patch
broadcom-sta-5.100.82.112-linux-3.8.patch                 broadcom-sta-6.30.223.141-makefile.patch
broadcom-sta-5.100.82.112-linux-3.9.patch                 broadcom-sta-6.30.223.30-linux-3.10.0.patch
broadcom-sta-5.100.82.112-remove-rssi-errors.patch        broadcom-sta-6.30.223.30-linux-3.9.0.patch
broadcom-sta-5.100.82.38-gcc.patch                        broadcom-sta-6.30.223.30-makefile.patch
gentoo ~ (0) #
Comment 4 Eric Siskonen 2014-05-31 02:33:34 UTC
I can also verify that this patch is indeed missing. I have several machines with the same symptom and I just performed another portage rsync.
Comment 5 Eric Siskonen 2014-05-31 18:34:40 UTC
This bug quite obviously lives in the new ebuild.

# diff broadcom-sta-6.30.223.141.ebuild broadcom-sta-6.30.223.141-r1.ebuild                                         
1c1                                                                                                                                                                           
< # Copyright 1999-2013 Gentoo Foundation                                                                                                                                     
---                                                                                                                                                                           
> # Copyright 1999-2014 Gentoo Foundation                                                                                                                                     
3c3                                                                                                                                                                           
< # $Header: /var/cvsroot/gentoo-x86/net-wireless/broadcom-sta/broadcom-sta-6.30.223.141.ebuild,v 1.1 2013/10/16 01:07:10 tomwij Exp $                                        
---                                                                                                                                                                           
> # $Header: /var/cvsroot/gentoo-x86/net-wireless/broadcom-sta/broadcom-sta-6.30.223.141-r1.ebuild,v 1.1 2014/05/30 12:23:12 swift Exp $                                      
15c15                                                                                                                                                                         
< KEYWORDS="-* ~amd64 ~x86"                                                                                                                                                   
---                                                                                                                                                                           
> KEYWORDS="~amd64 ~x86"                                                                                                                                                      
41c41                                                                                                                                                                         
<               CONFIG_CHECK="${CONFIG_CHECK} ${CONFIG_CHECK2} CFG80211 ~!PREEMPT_RCU"                                                                                        
---                                                                                                                                                                           
>               CONFIG_CHECK="${CONFIG_CHECK} ${CONFIG_CHECK2} CFG80211 ~!PREEMPT_RCU ~!PREEMPT"                                                                              
62,66c62,63                                                                                                                                                                   
<       epatch "${FILESDIR}/${P}-license.patch"
<       epatch "${FILESDIR}/${P}-makefile.patch"
<       epatch "${FILESDIR}/${P}-linux-recent.patch"
<       epatch "${FILESDIR}/${P}-eth-to-wlan.patch"
<       epatch "${FILESDIR}/${P}-gcc.patch"
---
>       epatch "${FILESDIR}/${P}-makefile.patch" \
>               "${FILESDIR}/${P}-linux-3.10.0.patch"

The new epatch line is similar but not identical to the broadcom-sta-6.30.223.30-r2.ebuild. I'm going to verify that replacing the previous epatch lines in an overlay resolves the problem.
Comment 6 Eric Siskonen 2014-05-31 19:33:01 UTC
Created attachment 377956 [details]
Modified broadcom-sta-6.30.223.141-r1.ebuild to revert changes to epatch.

Modified broadcom-sta-6.30.223.141-r1.ebuild to revert changes to epatch.
Comment 7 Eric Siskonen 2014-05-31 19:34:55 UTC
I can confirm reverting the changes to epatch in this ebuild fixes the issue. If you are desperate to get your broadcom-sta drivers working again (without having to revert to the previous version) you can create a local overlay and use this ebuild.
Comment 8 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2014-06-01 19:02:29 UTC
Not sure what's going on here; I assume swift made an error, given a build or repoman check would have covered this. If not, reassign to tomboy64 for further instructions on how we could fix this up; I'm not sure if we were provided that patch at all, or whether that patch is just supposed to be the previous one.
Comment 9 M. B. 2014-06-01 23:13:38 UTC
Created attachment 378036 [details, diff]
broadcom-sta-6.30.223.141-linux-3.10.0.patch

I'm not sure what happened, either; the patch was required before, but it's not listed as a dead file.
And it was definitely working the whole time in my overlay.

Anyway, here it is, until it's propagated again through portage.
You can also get it through my overlay, tbc on layman.

Regards,
tomboy64
Comment 10 Mike Nerone 2014-06-02 19:43:51 UTC
(In reply to M. B. from comment #9)
> I'm not sure what happened, either; the patch was required before, but it's
> not listed as a dead file.

Just to (hopefully) prevent any confusion from this statement, that's not correct. As shown in the diff to the previous ebuild in comment #5, this patch was not required before. It's a new file that was simply overlooked somehow.
Comment 11 Sven Vermeulen (RETIRED) gentoo-dev 2014-06-02 19:51:04 UTC
Weird... I haven't added in the patch, but repoman doesn't complain:

"""
$ repoman manifest && repoman full
>>> Creating Manifest for /home/swift/Development/Centralized/gentoo-x86/net-wireless/broadcom-sta

RepoMan scours the neighborhood...

Note: use --include-dev (-d) to check dependencies for 'dev' profiles

RepoMan sez: "If everyone were like you, I'd be out of business!"
"""

The commit was done through repoman as well (cfr ChangeLog and commit message being the same).

I'll add in the patch.
Comment 12 Sven Vermeulen (RETIRED) gentoo-dev 2014-06-02 19:58:56 UTC
Patch committed