511804 – OpenRC: tmpfiles.d's parser does not recognize unix styled comments

Bug 511804 - OpenRC: tmpfiles.d's parser does not recognize unix styled comments

Summary: OpenRC: tmpfiles.d's parser does not recognize unix styled comments

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Hosted Projects
Classification:	Unclassified
Component:	OpenRC (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	OpenRC Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	481182
	Show dependency tree

Reported:	2014-05-29 18:11 UTC by consus
Modified:	2014-06-21 00:46 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
This patch fixes the issue. (openrc.patch,942 bytes, patch) 2014-05-29 18:12 UTC, consus	Details \| Diff
Fixed patch (openrc.patch,659 bytes, patch) 2014-05-29 18:18 UTC, consus	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description consus 2014-05-29 18:11:03 UTC

This line is considered valid

  1 |# Comment

however, on this one

  1| #Comment

tmpfiles.d's parser fails.
 
For example, parsing /usr/lib/tmpfiles.d/tor.conf (net-misc/tor) fails on the first line.

Reproducible: Always

Steps to Reproduce:
1. Modify an entry (or create a new one) in /usr/lib/tmpfiles.d
2. Run `rc-service tmpfiles.setup restart'
Actual Results:  
The 'ignoring invalid entry on line...' warning was printed.

Expected Results:  
The parser should not have failed on a comment.

Comment 1 consus 2014-05-29 18:12:42 UTC

Created attachment 377818 [details, diff]
This patch fixes the issue.

Comment 2 consus 2014-05-29 18:18:32 UTC

Created attachment 377820 [details, diff]
Fixed patch

Sorry, accidentally removed the wrong block.

Comment 3 William Hubbs gentoo-dev

2014-06-21 00:46:37 UTC

This is fixed in commit 094bc17 and will be in OpenRC-0.13.
Thanks for the report.