Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 511554 - app-emulation/wine-1.7.19 USE=pipelight should probably not apply compholio's '10-Missing-Fonts'
Summary: app-emulation/wine-1.7.19 USE=pipelight should probably not apply compholio's...
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Wine Maintainers
URL: https://github.com/compholio/wine-com...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-05-26 17:00 UTC by Torsten Kurbad
Modified: 2014-05-27 11:05 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
wine-1.7.19.ebuild_no_font_replacement.patch (wine-1.7.19-r1.ebuild.patch,1.34 KB, patch)
2014-05-26 17:01 UTC, Torsten Kurbad
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Kurbad 2014-05-26 17:00:47 UTC
First of all, I read the disclaimer on the inofficial pipelight patches for wine. :-)

Nonetheless, there's an issue with the patches themselves that could easily be resolved:

Compholio's patchset includes replacing Arial by Liberation Sans, a font that doesn't seem to recognize the font smoothing capabilities of wine. Thus, applications using the Arial font will start to look extremely ugly, making the text barely readable on flat screen monitors.

According to the upstream discussion I just had, the 'real' Arial would work just fine. The replacement is merely done because of redistribution issues with Microsoft's corefonts package.

Since corefonts is available in portage, an easy solution to the problem would be to
a) let the wine ebuild depend on media-fonts/corefonts, while the 'pipelight' USE flag is set

AND

b) not to apply the binary patchset "10-Missing_Fonts" from the compholio patchset.

I'll attach a patch to the ebuild that does just that and works fine for me.

Any thoughts?

Reproducible: Always
Comment 1 Torsten Kurbad 2014-05-26 17:01:52 UTC
Created attachment 377674 [details, diff]
wine-1.7.19.ebuild_no_font_replacement.patch
Comment 2 Michael Müller 2014-05-26 17:12:21 UTC
Hi,

if you modify the patches, you should also regenerate the patch list by executing

./debian/tools/generate-patchlist.sh > ./patches/patch-list.patch

otherwise "wine --patches" shows patches which were not applied during the build.

Michael
Comment 3 Alexandre Rostovtsev (RETIRED) gentoo-dev 2014-05-26 17:56:56 UTC
We've had complaints before about wine pulling in corefonts - some users really don't like non-free fonts on their system. Probably this needs to be controlled by a USE flag.
Comment 4 Alexandre Rostovtsev (RETIRED) gentoo-dev 2014-05-26 18:00:18 UTC
Thinking a bit further: at runtime, wine should be using Microsoft's Arial if it's available, and if it's not available, falling back to the patched-in Liberation alternative. If this doesn't happen, that would seem to be a bug in the Compholio patchset.
Comment 5 Torsten Kurbad 2014-05-26 18:16:55 UTC
(In reply to Michael Müller from comment #2)
> ./debian/tools/generate-patchlist.sh > ./patches/patch-list.patch
> 
> otherwise "wine --patches" shows patches which were not applied during the
> build.

Thanks for the hint.
Comment 6 Torsten Kurbad 2014-05-26 18:17:58 UTC
(In reply to Alexandre Rostovtsev from comment #3)
> We've had complaints before about wine pulling in corefonts - some users
> really don't like non-free fonts on their system.

Oh, I didn't know that.

> Probably this needs to be controlled by a USE flag.

That would be a nice option, yes!
Comment 7 Torsten Kurbad 2014-05-26 18:20:25 UTC
(In reply to Alexandre Rostovtsev from comment #4)
> Thinking a bit further: at runtime, wine should be using Microsoft's Arial
> if it's available, and if it's not available, falling back to the patched-in
> Liberation alternative.

That sounds reasonable and I'm about to re-open the upstream issue with that observation.

So maybe we should first see what upstream has to say to this proposal?
Comment 8 Torsten Kurbad 2014-05-27 09:29:33 UTC
Hi,

according to https://bugzilla.redhat.com/show_bug.cgi?id=984230 the missing font smoothing seems to be a 'bug' in the liberation fonts package for versions >= 2.00.

I reported this upstream and am just now trying to build wine with a modified patchset that includes Liberation Sans 1.07.3 as Arial replacement, instead of the 2.01 which is used by compholio.

If that works it might be the mos elegant solution by means of simplicity.

Best,
Torsten
Comment 9 Torsten Kurbad 2014-05-27 11:05:28 UTC
I just provided a pull request upstream that replaces Liberation Sans by an older version.

For me, this works perfectly and solves all the font smoothing issues without having to resort to corefonts.

Since the issue will eventually be resolved upstream, I'm closing this bug.

Best,
Torsten