Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 511188 - gnome-extra/polkit-gnome should set OnlyShowIn=GNOME;Unity; in desktop entry
Summary: gnome-extra/polkit-gnome should set OnlyShowIn=GNOME;Unity; in desktop entry
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Freedesktop bugs
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-05-24 10:13 UTC by Quentin Minster
Modified: 2014-05-24 14:56 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
polkit-gnome-0.105-r2.ebuild (polkit-gnome-0.105-r2.ebuild,1.19 KB, text/plain)
2014-05-24 10:20 UTC, Quentin Minster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Quentin Minster 2014-05-24 10:13:40 UTC
The .desktop entry for polkit-gnome uses:
 NotShowIn=MATE;KDE;

This is nice but does not prevent autostarting in more exotic setups that are neither MATE nor KDE (nor GNOME nor Unity, which want the thing to autostart anyway).

I suggest the following:
 OnlyShowIn=GNOME;Unity;

As per #509086, MATE could be added to this list later on.


Reproducible: Always

Steps to Reproduce:
1. emerge gnome-extra/polkit-gnome
2. dex -vad -e Blah
  (from x11-misc/dex ; -e specifies the environment for autostart entries, typically that would be 'GNOME' inside GNOME, 'KDE' inside KDE... this is matched against OnlyShowIn/NotShowIn ; -d is for --dry-run so this command won't actually run anything)
Actual Results:  
dex reports it would have autostarted /etc/xdg/autostart/polkit-gnome-authentication-agent-1.desktop

Expected Results:  
polkit-gnome-authentication-agent-1.desktop should not autostart in environment 'Blah' which has nothing to do with GNOME
Comment 1 Quentin Minster 2014-05-24 10:20:32 UTC
Created attachment 377564 [details]
polkit-gnome-0.105-r2.ebuild

* use OnlyShowIn instead of NotShowIn
* bump to EAPI 5
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2014-05-24 11:02:20 UTC
Comment on attachment 377564 [details]
polkit-gnome-0.105-r2.ebuild

--- polkit-gnome-0.105-r1.ebuild        2014-02-28 15:14:24.000000000 +0100
+++ -   2014-05-24 13:02:03.001899737 +0200
@@ -2,7 +2,7 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /var/cvsroot/gentoo-x86/gnome-extra/polkit-gnome/polkit-gnome-0.105-r1.ebuild,v 1.1 2014/02/28 14:14:24 ssuominen Exp $
-EAPI=4
+EAPI=5
 inherit gnome.org
 DESCRIPTION="A dbus session bus service that is used to bring up authentication dialogs"
@@ -36,7 +36,7 @@
        Type=Application
        Categories=
        NoDisplay=true
-       NotShowIn=MATE;KDE;
+       OnlyShowIn=GNOME;Unity;
        AutostartCondition=GNOME3 if-session gnome-fallback
        EOF
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2014-05-24 12:01:12 UTC
(In reply to Quentin Minster from comment #0)
> The .desktop entry for polkit-gnome uses:
>  NotShowIn=MATE;KDE;
> 
> This is nice but does not prevent autostarting in more exotic setups that
> are neither MATE nor KDE (nor GNOME nor Unity, which want the thing to
> autostart anyway).

that's the purpose, gnome-extra/polkit-gnome is a generic GTK+ policykit agent, pulled in by USE="gtk" of sys-auth/polkit for Xfce, LXDE, ROX, GNOME, and everything supporting XDG autostart

> I suggest the following:
>  OnlyShowIn=GNOME;Unity;

That would break the agent for every desktop except GNOME and Unity

You clearly have misunderstood the purpose of polkit-gnome, don't let the name "gnome" confuse you in it, it's a generic purpose GTK+ -only agent, as in, no other deps than GTK+, it might as well be called 'polkit-gtk', but since it was delevelop by GNOME people, the name is what it is
Comment 4 Quentin Minster 2014-05-24 14:56:51 UTC
(In reply to Samuli Suominen from comment #3)
> (In reply to Quentin Minster from comment #0)
> > The .desktop entry for polkit-gnome uses:
> >  NotShowIn=MATE;KDE;
> > 
> > This is nice but does not prevent autostarting in more exotic setups that
> > are neither MATE nor KDE (nor GNOME nor Unity, which want the thing to
> > autostart anyway).
> 
> that's the purpose, gnome-extra/polkit-gnome is a generic GTK+ policykit
> agent, pulled in by USE="gtk" of sys-auth/polkit for Xfce, LXDE, ROX, GNOME,
> and everything supporting XDG autostart
> 
> > I suggest the following:
> >  OnlyShowIn=GNOME;Unity;
> 
> That would break the agent for every desktop except GNOME and Unity
> 
> You clearly have misunderstood the purpose of polkit-gnome, don't let the
> name "gnome" confuse you in it, it's a generic purpose GTK+ -only agent, as
> in, no other deps than GTK+, it might as well be called 'polkit-gtk', but
> since it was delevelop by GNOME people, the name is what it is

Ok, got it. Sorry for the noise here. =/