Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 510852 - net-wireless/chillispot - macallowed doesn't work or kills chillispot
Summary: net-wireless/chillispot - macallowed doesn't work or kills chillispot
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL: http://www.chillispot.org/chilliforum...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-05-20 13:49 UTC by Joe Kane
Modified: 2016-11-09 10:28 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Kane 2014-05-20 13:49:42 UTC
chillispot can allow certain mac addresses without authentication using macallowed flag.  this either kills chillispot or is ignored

Reproducible: Always

Steps to Reproduce:
1. add mac to macallowed list
2. try to start chillispot
3. bork (termiantion no message)


Expected Results:  
allowed bypass of chillispot login

diff -r -u chillispot-1.1.0/src/chilli.c chillispot-1.1.0-macallowed/src/chilli.c
--- chillispot-1.1.0/src/chilli.c       2006-09-24 19:48:25.000000000 +0200
+++ chillispot-1.1.0-macallowed/src/chilli.c    2008-07-18 07:58:03.000000000 +0200
@@ -534,6 +534,8 @@
     }
   }
   free(p3);
+
+  return 0;
}

int static process_options(int argc, char **argv, int firsttime) {
@@ -2991,7 +2993,7 @@

   /* Get Service Type */
   if (!radius_getattr(pack, &stateattr, RADIUS_ATTR_SERVICE_TYPE, 0, 0, 0)) {
-    if(ntohl(attr->v.i) == RADIUS_SERVICE_TYPE_CHILLISPOT_AUTHORIZE_ONLY) {
+    if(ntohl(stateattr->v.i) == RADIUS_SERVICE_TYPE_CHILLISPOT_AUTHORIZE_ONLY) {
       sys_err(LOG_ERR, __FILE__, __LINE__, 0,
              "Chillispot-Authorize-Only Service-Type in Access-Accept");
       return dnprot_reject(appconn);
Comment 1 Joe Kane 2014-05-20 14:06:49 UTC
diff below does work for me, hopefully will work for others
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2014-05-20 21:03:03 UTC
*** Bug 510806 has been marked as a duplicate of this bug. ***
Comment 3 Pacho Ramos gentoo-dev 2016-02-18 11:26:25 UTC
would you be willing to proxy maintain this package?
https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers
Comment 4 Pacho Ramos gentoo-dev 2016-11-09 10:28:15 UTC
removed