Bug 510232 – app-emulation/vmware-modules - udevd[240]: invalid key/value pair in file /lib64/udev/rules.d/60-vmware.rules on line 1,starting at character 32 (' ')

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description morpheus 2014-05-13 12:39:30 UTC]

Created attachment 376824 [details, diff]
patch

vmware-modules-279.2 causes following when the system is running eudev-1.6:

[    5.029681] udevd[240]: invalid key/value pair in file /lib64/udev/rules.d/60-vmware.rules on line 1,starting at character 32 (' ')
[    5.029692] udevd[240]: invalid key/value pair in file /lib64/udev/rules.d/60-vmware.rules on line 2,starting at character 36 (' ')
[    5.029699] udevd[240]: invalid key/value pair in file /lib64/udev/rules.d/60-vmware.rules on line 3,starting at character 32 (' ')
[    5.029705] udevd[240]: invalid key/value pair in file /lib64/udev/rules.d/60-vmware.rules on line 4,starting at character 32 (' ')

The patch for the ebuild in the attachment gets rid of theese messages.

[Comment 1 Harris Landgarten 2014-05-13 18:52:09 UTC]

same with systemd

[Comment 2 Greg Turner 2014-05-22 09:31:31 UTC]

see:

https://github.com/gmt/gmt-vmware-overlay/blob/master/app-emulation/vmware-modules/vmware-modules-279.2-r1.ebuild#L113

for a solution to this.

[Comment 3 Michael Rowell 2014-05-28 19:13:28 UTC]

(In reply to Greg Turner from comment #2)
> see:
> 
> https://github.com/gmt/gmt-vmware-overlay/blob/master/app-emulation/vmware-
> modules/vmware-modules-279.2-r1.ebuild#L113
> 
> for a solution to this.

I know it's how the old ebuild does it, but is catting the file necessary? Wouldn't a premade "files/60-vmware.rules" be the correct way of doing things? I mean, to quote the devmanual at http://devmanual.gentoo.org/tools-reference/cat/:

"If you find yourself about to use cat in an ebuild, stop and reconsider. It is almost always unnecessary."

Seems like we could clean this up a bit while we're looking at it...

[Comment 4 Mike Gilbert 2014-05-28 20:25:06 UTC]

(In reply to Michael Rowell from comment #3)

Read the next section in the devmanual. To quote:

> On the other hand, cat is exceptionally useful for so-called "here" documents...
> For such small files as the example above, a set of here documents is more elegant, and easier to maintain, than the equivalent bunch of files floating about in ${FILESDIR} would be.

[Comment 5 Evan Teran 2015-07-11 04:47:04 UTC]

The latest official vmware overlay has had the version bumped.

I have built the sources for vmware-modules-{271,279,304} on stock kernels 3.10 - 4.0, and associated vmware-workstation-{9,10,11} ebuilds.

Please give those a try and let me know if you have any issues.

Thanks