Bug 51001 – reiserfsprogs 3.6.16 build fails with 2.6 kernel headers: undefined reference to IDE_DISK_MAJOR

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Ed Catmur 2004-05-13 20:09:05 UTC]

gcc  -O3 -pipe -march=athlon-xp -mmmx -msse -m3dnow -mfpmath=387 -momit-leaf-frame-pointer -ftracer -fweb -fomit-frame-pointer -ffast-math -falign-functions=64 -falign-loops=4 -falign-jumps=4 -funroll-loops -fprefetch-loop-arrays -fno-pic -nopie -fPIC -DPIC   -o reiserfsck  main.o pass0.o pass1.o pass2.o semantic_check.o semantic_rebuild.o pass4.o lost+found.o ubitmap.o uobjectid.o ustree.o ufile.o check_tree.o info.o super.o ../lib/libmisc.a ../reiserfscore/libcore.a -luuid
../lib/libmisc.a(misc.o)(.text+0x19b8): In function `prepare_dma_check':
: undefined reference to `IDE_DISK_MAJOR'
../lib/libmisc.a(misc.o)(.text+0x1a41): In function `prepare_dma_check':
: undefined reference to `IDE_DISK_MAJOR'
../reiserfscore/libcore.a(reiserfslib.o)(.text+0x2eb6): In function `can_we_format_it':
: undefined reference to `IDE_DISK_MAJOR'
../reiserfscore/libcore.a(reiserfslib.o)(.text+0x2ec8): In function `can_we_format_it':
: undefined reference to `SCSI_BLK_MAJOR'
collect2: ld returned 1 exit status
make[1]: *** [reiserfsck] Error 1
make[1]: Leaving directory `/var/tmp/portage/reiserfsprogs-3.6.16/work/reiserfsprogs-3.6.16/fsck'

http://lxr.linux.no/ident?v=2.4.26;i=IDE_DISK_MAJOR
http://lxr.linux.no/ident?v=2.6.0;i=IDE_DISK_MAJOR

Someone at Namesys needs the cluestick treatment. :D

[Comment 1 Ed Catmur 2004-05-13 21:15:56 UTC]

I'm an idiot; that's kernel headers not the kernel itself.

Lowering severity accordingly - I have no idea how P1-P5 corresponds to actual priority, or I would do that as well.

[Comment 2 Pete Plank 2004-05-14 00:50:34 UTC]

Found a patch for this on the reiserfs list.

Writeup at http://marc.theaimsgroup.com/?l=reiserfs&m=108448892101094&w=2

--- reiserfsprogs-3.6.16.orig/include/misc.h    2004-02-17 13:20:40.000000000 +0100
+++ reiserfsprogs-3.6.16.patched/include/misc.h 2004-05-14 00:49:31.000000000 +0200
@@ -154,14 +154,11 @@
     tmp >>= from;\
     return tmp;
 
-#if 0
 #ifndef major
 #define major(rdev)      ((rdev)>>8)
 #define minor(rdev)      ((rdev) & 0xff)
 #endif /* major */
-#endif
 
-#if 0
 #ifndef SCSI_DISK_MAJOR
 #define SCSI_DISK_MAJOR(maj) ((maj) == SCSI_DISK0_MAJOR || \
                             ((maj) >= SCSI_DISK1_MAJOR && (maj) <= SCSI_DISK7_MAJOR))
@@ -184,6 +181,5 @@
                             (maj) == IDE4_MAJOR || (maj) == IDE5_MAJOR)
 #endif /* IDE9_MAJOR */
 #endif /* IDE_DISK_MAJOR */
-#endif
 
 #endif /* REISERFS_MISC_H */

[Comment 3 Mauricio L. Pilla (RETIRED) 2004-05-14 06:54:31 UTC]

the patch allowed me to compile it.

[Comment 4 Lourdes Jones 2004-05-14 08:18:51 UTC]

reiserfsprogs-3.6.17 includes the compile fix.  Time for another version bump.

[Comment 5 Brandon Low (RETIRED) 2004-05-14 09:10:55 UTC]

Will commit shortly, thanks.

[Comment 6 Kathy Wills 2004-05-14 10:38:49 UTC]

The patch worked for me too.