Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 509204 - elibc_Cygwin and elibc_Winnt should be masked in profile/base and unmasked in profile/prefix
Summary: elibc_Cygwin and elibc_Winnt should be masked in profile/base and unmasked in...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-30 21:53 UTC by Anthony Basile
Modified: 2014-04-30 22:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Basile gentoo-dev 2014-04-30 21:53:11 UTC
In working with various ELIBC's I started fixing up some pieces in the profiles that were not properly sync-ed up.  I think everyhing is pretty much cleaned up, except for:

1. elibc_Winnt which should be masked in profile/base/use.mask.  It is already unmasked in profiles/prefix/windows/winnt/use.mask

2. elibc_Cygwin which should be masked in profile/base/use.mask and unmasked in profiles/prefix/windows/cygwin/use.mask

I was about to do so but I don't want to start breaking people's systems.


Reproducible: Always
Comment 1 Anthony Basile gentoo-dev 2014-04-30 21:57:18 UTC
BTW, just to be clear.  Here's where there should be reference to non-glibc elibc flags:

1. base/make.defaults should include the flag in USE_EXPAND_VALUES_ELIBC

2. desc/elibc.desc should include a description of the flag

3. base/use.mask should mask the flag.  In case the libc is provided by a package (eg sys-lib/musl) then that package should be masked in base/package.mask.

4. profiles/<path-to-profile>/use.mask should unmask the flag.  If the libc is provided by a package, then that package should be unmasked in profiles/<path-to-profile>/package.mask

With so many pieces that need to be sync-ed manually, its no wonder we got a bit messy.
Comment 2 Anthony Basile gentoo-dev 2014-04-30 22:09:36 UTC
Committed with ack form redlizard.  We should be good now:

# cvs diff
X11 forwarding request failed on channel 0
Index: base/use.mask
===================================================================
RCS file: /var/cvsroot/gentoo-x86/profiles/base/use.mask,v
retrieving revision 1.196
diff -u -B -r1.196 use.mask
--- base/use.mask	26 Apr 2014 11:03:58 -0000	1.196
+++ base/use.mask	30 Apr 2014 22:05:46 -0000
@@ -165,6 +165,7 @@
 userland_BSD
 
 elibc_AIX
+elibc_Cygwin
 elibc_Darwin
 elibc_DragonFly
 elibc_FreeBSD
@@ -176,6 +177,7 @@
 elibc_OpenBSD
 elibc_SunOS
 elibc_uclibc
+elibc_Winnt
 
 kernel_AIX
 kernel_Darwin
cvs diff: prefix/windows/cygwin/use.mask is a new entry, no comparison available

------------

# cat prefix/windows/cygwin/use.mask 
# Copyright 1999-2014 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: /var/cvsroot/gentoo-x86/profiles/prefix/windows/cygwin/use.mask,v 1.1 2014/04/30 22:07:29 blueness Exp $

# Re-add Cygwin's libc
-elibc_Cygwin

------------

# cat prefix/windows/winnt/use.mask | grep elibc
-elibc_Winnt