Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 508992 - =media-sound/easytag-2.2.2: version bump
Summary: =media-sound/easytag-2.2.2: version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Sound Team
URL: https://mail.gnome.org/archives/easyt...
Whiteboard:
Keywords:
Depends on:
Blocks: 509032
  Show dependency tree
 
Reported: 2014-04-28 17:48 UTC by Manuel Rüger (RETIRED)
Modified: 2014-05-11 11:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rüger (RETIRED) gentoo-dev 2014-04-28 17:48:54 UTC
Tue, 22 Apr 2014 

Please add it to the tree
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2014-05-09 19:11:09 UTC
2.2.2 in portage :)
Comment 2 Mikael Magnusson 2014-05-10 12:59:49 UTC
Any particular reason you removed the gtk2 useflag again?
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2014-05-10 13:03:55 UTC
(In reply to Mikael Magnusson from comment #2)
> Any particular reason you removed the gtk2 useflag again?

Any particular reason there should be an USE flag for it? Upstream default is GTK+ 3.x and far as I've looked, everything is supported by it, no features removed
If you have a reason, I'll add something like USE="+deprecated" like www-client/midori has to enable GTK 2.x by default, if using GTK+ 3.x takes something away from the app

And no, theming is not an answer of anykind, that's already solved by up-to-date themes like gtk-engines-xfce:2 and :3, or Adwaita, or Greybird, or Zukitwo, or number of other modern themes
No point in making users read the sourcecode/ebuild for determining which they want, if re-enabling GTK+-2.x brings nothing useful
Comment 4 Ben de Groot (RETIRED) gentoo-dev 2014-05-11 10:08:37 UTC
(In reply to Samuli Suominen from comment #3)
> (In reply to Mikael Magnusson from comment #2)
> > Any particular reason you removed the gtk2 useflag again?
> 
> Any particular reason there should be an USE flag for it? 

Gentoo is not in the habit of removing perfectly valid options from users. Some of us have no use for gtk+:3. As long as upstream does not remove this option, neither should we.

Please don't do this again. I have restored it once more.
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2014-05-11 10:48:34 UTC
(In reply to Ben de Groot from comment #4)
> (In reply to Samuli Suominen from comment #3)
> > (In reply to Mikael Magnusson from comment #2)
> > > Any particular reason you removed the gtk2 useflag again?
> > 
> > Any particular reason there should be an USE flag for it? 
> 
> Gentoo is not in the habit of removing perfectly valid options from users.
> Some of us have no use for gtk+:3. As long as upstream does not remove this
> option, neither should we.

We are not in habit of providing USE flags for useless ./configure flags, specially for deprecated libraries, we don't do that for eg. USE="udisks1 udisks2" or other SLOTted packages either. GTK+ 3.x is an upgrade over GTK+ 2.x

> Please don't do this again. I have restored it once more.

And I'll remove it next time I'll touch the ebuild.
Comment 6 Ben de Groot (RETIRED) gentoo-dev 2014-05-11 11:21:35 UTC
(In reply to Samuli Suominen from comment #5)
> 
> We are not in habit of providing USE flags for useless ./configure flags,

Having the option of using GTK2 is not useless. For a number of users installing GTK3 would be useless. Don't force them to do that when it's not necessary.

> specially for deprecated libraries,

GTK2 is not deprecated. It is still maintained and widely used.

> GTK+ 3.x is an upgrade over GTK+ 2.x

That is debatable. We have users who disagree.

> > Please don't do this again. I have restored it once more.
> 
> And I'll remove it next time I'll touch the ebuild.

You are being uncooperative for no good reason. It doesn't hurt anyone to have this option in the ebuild. Please let's not descend into a commit/revert war.
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2014-05-11 11:28:54 UTC
i've maintained the package since 2007, down to the day i've punted gtk1 easytag from portage due to same reasons. just look at ChangeLog
i'm pretty sure i as a maintainer of the package can drop useless USE flags from it, if i want to
plus you broke the ebuild by introducing a second REQUIRED_USE, now there is 2