Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 508340 - app-emulation/libvirt-1.2.3 - add USE=wireshark to select dissector build / automagic dependency on net-analyzer/wireshark
Summary: app-emulation/libvirt-1.2.3 - add USE=wireshark to select dissector build / a...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matthias Maier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 508336
  Show dependency tree
 
Reported: 2014-04-21 17:27 UTC by Reto Gantenbein (ganto)
Modified: 2014-11-03 01:33 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
libvirt-1.2.3-r1.ebuild with new 'wireshark' USE flag (libvirt-1.2.3-r1.ebuild,11.93 KB, text/plain)
2014-04-21 18:32 UTC, Reto Gantenbein (ganto) 		Details
app-emulation:libvirt-1.2.6:20140729-145831.log.lz (app-emulation:libvirt-1.2.6:20140729-145831.log.lz,31.48 KB, application/x-lzip)
2014-07-29 15:13 UTC, Michał Górny 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Reto Gantenbein (ganto) 2014-04-21 17:27:26 UTC 
Libvirt-1.2.2 has introduced an additional feature which is a wireshark dissector for analyzing the libvirt RPC protocol. The build of this feature is selected during the configure phase of the libvirt build, depending on whether wireshark is found on the build server or not. Here the corresponding (newly introduced) configure switch:

  --with-wireshark-dissector
                          enable wireshark dissector plugin support
                          [default=check]


This behaviour results in two minor annoyances:

1) depending on the build order of libvirt and wireshark, the resulting libvirt build is different

2) it's not possible to disable the wireshark dissector plugin, e.g. in case there are build problems (also see #508336)

I think it would be a good idea to have a USE flag 'wireshark' which allows to enable/disable this feature and correctly pulls in the net-analyzer/wireshark dependency if enabled.

Reproducible: Always

Steps to Reproduce:
1. (emerge wireshark)
2. ACCEPT_KEYWORDS="~amd64" emerge =libvirt-1.2.3

Actual Results:  
Libvirt wireshark dissector plugin is built depending on the availability of wireshark.

Expected Results:  
The build of the dissector plugin can be explicitly enabled or disabled.
Comment 1 Reto Gantenbein (ganto) 2014-04-21 18:32:08 UTC 
Created attachment 375432 [details]
libvirt-1.2.3-r1.ebuild with new 'wireshark' USE flag

I quickly created an ebuild with a new 'wireshark' USE flag. Due to #508336 net-analyzer/wireshark-1.11.3 is not supported yet. I only tested with wireshark 1.10.6 which works fine.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-07-29 15:13:22 UTC 
Created attachment 381820 [details]
app-emulation:libvirt-1.2.6:20140729-145831.log.lz

Bump. This causes a build failure w/ 1.2.6.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-07-31 17:06:35 UTC 
+  31 Jul 2014; Michał Górny <mgorny@gentoo.org> libvirt-1.2.3.ebuild,
+  libvirt-1.2.5.ebuild, libvirt-1.2.6.ebuild, libvirt-9999.ebuild:
+  Disable wireshark dissector support to fix automagic dependency and resulting
+  build failures, bugs #508340 and #508336.

I leave any further actions up to the maintainers.
Comment 4 Matthias Maier gentoo-dev 2014-11-03 01:33:49 UTC 
*libvirt-1.2.9-r1 (03 Nov 2014)

  03 Nov 2014; Matthias Maier <tamiko@gentoo.org>
  +files/libvirt-1.2.9-do_not_use_sysconf.patch, +files/libvirtd.service.conf,
  +libvirt-1.2.9-r1.ebuild, -files/libvirt-1.2.6-numa.patch,
  libvirt-9999.ebuild, metadata.xml:
  add wireshark-plugins use flag, bug 508340; do not install into runtime paths,
  bug 520408; do not install into units use /etc/sysconfig, bug 477524