It's a build system bug. dev-qt/qttest is not needed if we do not build the tests also, the ebuild should probably use the cmake option: option(ECHONEST_BUILD_TESTS "Build all unit tests" ON) in one way or another
that means I tested the build with qttest uninstalled and sed -i -e '/find_package/s/QtTest//' CMakeLists.txt || die
Nikoli, OK to drop the dep and push the sed line in? I trust you test this ;)
> also, the ebuild should probably use the cmake option: option(ECHONEST_BUILD_TESTS "Build all unit tests" ON) libechonest-2.2.0-r1.ebuild already has -DECHONEST_BUILD_TESTS=OFF, will check if qttest is required.
(In reply to Nikoli from comment #3) > > also, the ebuild should probably use the cmake option: > option(ECHONEST_BUILD_TESTS "Build all unit tests" ON) > > libechonest-2.2.0-r1.ebuild already has -DECHONEST_BUILD_TESTS=OFF, will > check if qttest is required. my tree must be out of date then
btw. it's not clear to me why the tests are restricted the tests of curl also need a network connection afais... I personally wouldn't make that a blocker
> btw. it's not clear to me why the tests are restricted The general rule is too disable tests which fail without connection to internet or with FEATURES=network-sandbox > the tests of curl also need a network connection afais... and curl ebuild has RESTRICT="test"
(In reply to Nikoli from comment #6) > and curl ebuild has RESTRICT="test" Yes, but not because of that reason.
see bug 285669 for an explanation
Nikoli, OK to commit following? --- libechonest-2.2.0-r1.ebuild +++ libechonest-2.2.0-r1.ebuild @@ -19,8 +19,7 @@ RDEPEND=">=dev-libs/qjson-0.5 dev-qt/qtcore:4" DEPEND="${RDEPEND} - virtual/pkgconfig - dev-qt/qttest:4" + virtual/pkgconfig" DOCS=( AUTHORS README TODO )
(In reply to Samuli Suominen from comment #9) > Nikoli, OK to commit following? > > --- libechonest-2.2.0-r1.ebuild > +++ libechonest-2.2.0-r1.ebuild > @@ -19,8 +19,7 @@ > RDEPEND=">=dev-libs/qjson-0.5 > dev-qt/qtcore:4" > DEPEND="${RDEPEND} > - virtual/pkgconfig > - dev-qt/qttest:4" > + virtual/pkgconfig" > > DOCS=( AUTHORS README TODO ) That might fail without the sed (at least for 2.1.0).
I prefer to wait until patch for this bug is accepted upstream.
(In reply to Nikoli from comment #11) > I prefer to wait until patch for this bug is accepted upstream. fixing build systems shouldn't need upstream approval... it's trivial enough
Even if it is trivial, it is not urgent - nothing is broken or insecure.
(In reply to Nikoli from comment #13) > Even if it is trivial, it is not urgent - nothing is broken or insecure. I fail to see an argument.
I would not get anything done in gentoo if I would follow that policy for trivial build system fixes...
Long as it's reported upstream, the fix can be pushed to Portage, or especially then it can be pushed to Portage So I've committed it to 2.2.0-r1