Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 506948 - media-video/mpv drop use of base.eclass
Summary: media-video/mpv drop use of base.eclass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Nikoli
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 497022
  Show dependency tree
 
Reported: 2014-04-06 14:29 UTC by Julian Ospald
Modified: 2014-04-06 19:23 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
patch for 0.3.7 and live ebuild (mpv-0.3.7.ebuild.patch,576 bytes, patch)
2014-04-06 16:01 UTC, Nikoli 		Details | Diff
patch for 0.3.7 and live ebuild (mpv-0.3.7.ebuild.patch,514 bytes, patch)
2014-04-06 18:04 UTC, Nikoli 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Ospald 2014-04-06 14:29:25 UTC 
base.eclass is about to be deprecated and should not be used any longer if possible
Comment 1 Nikoli 2014-04-06 14:46:16 UTC 
So what should be used instead of base_src_prepare? I need it for PATCHES=(  ) and epatch_user support.
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2014-04-06 14:47:50 UTC 
(In reply to Nikoli from comment #1)
> So what should be used instead of base_src_prepare? I need it for PATCHES=( 
> ) and epatch_user support.

inherit eutils

PATCHES=( "${FILESDIR}"/foo.patch )

src_prepare() {
[[ ${PATCHES[@]} ]] && epatch "${PATCHES[@]}"
epatch_user
}
Comment 3 Nikoli 2014-04-06 16:01:16 UTC 
Created attachment 374394 [details, diff]
patch for 0.3.7 and live ebuild

I hoped there is better way then duplicating same code in every ebuild, but if there is none, let add only epatch_user for now.
Comment 4 Julian Ospald 2014-04-06 17:57:54 UTC 
patch is unreadable
Comment 5 Nikoli 2014-04-06 18:04:36 UTC 
Created attachment 374410 [details, diff]
patch for 0.3.7 and live ebuild

Sorry, used wrong command for creating it.
Comment 6 Julian Ospald 2014-04-06 18:08:34 UTC 
(In reply to Nikoli from comment #5)
> Created attachment 374410188 [details189, diff190]
> patch for 0.3.7 and live ebuild
> 
> Sorry, used wrong command for creating it.

LGTM
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2014-04-06 19:23:22 UTC 
  06 Apr 2014; Tom Wijsman <TomWij@gentoo.org> mpv-0.3.7.ebuild,
  mpv-9999.ebuild:
  Replace base inherit by eutils inherit. Update FDO MIME desktop database and
  GNOME 2 icon list cache. Fixes bug #374402 and bug #374410, proxied commit for
  Nikoli.