Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 506942 - media-video/mpv double check dependencies
Summary: media-video/mpv double check dependencies
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Nikoli
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-06 14:15 UTC by Julian Ospald
Modified: 2014-04-07 18:38 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for 0.3.7 and live ebuild (mpv-0.3.7.ebuild.patch,352 bytes, patch)
2014-04-06 14:57 UTC, Nikoli
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Ospald 2014-04-06 14:15:20 UTC
> cdio? (
>	|| (
>		dev-libs/libcdio-paranoia
>		<dev-libs/libcdio-0.90[-minimal]
>	)
> )

but I get explicit linkage to both:
dev-libs/libcdio-paranoia (/usr/lib64/libcdio_cdda.so.1)
dev-libs/libcdio-paranoia (/usr/lib64/libcdio_paranoia.so.1)
dev-libs/libcdio (/usr/lib64/libcdio.so.14)

further I get explicit linkage to:
x11-libs/libX11 (/usr/lib64/libX11.so.6)

for USE="X" ...say it's nitpicky
Comment 1 Nikoli 2014-04-06 14:54:20 UTC
I think cdio deps are correct and standard, they were changed according to this tracker:
bug #452430

x11-libs/libX11 is indeed missing RDEPEND and DEPEND of USE X, most likely mplayer and mplayer2 ebuilds have same bug.
Comment 2 Nikoli 2014-04-06 14:57:58 UTC
Created attachment 374384 [details, diff]
patch for 0.3.7 and live ebuild
Comment 3 Julian Ospald 2014-04-06 15:54:20 UTC
(In reply to Nikoli from comment #1)
> I think cdio deps are correct and standard, they were changed according to
> this tracker:
> bug #452430161
> 

No, dev-libs/libcdio-paranoia already depends on dev-libs/libcdio.
There is no <dev-libs/libcdio-0.90[-minimal] in the tree anyway.

We have explicit linkage against both libraries, so we have to add both.
Comment 4 Julian Ospald 2014-04-06 15:56:38 UTC
but yeah, this is a bit nitpicky and not always distinguishable, so I have no strong opinion here
Comment 5 Julian Ospald 2014-04-06 16:01:35 UTC
Fact is that dev-libs/libcdio is used explicitly:

# grep cdio  */* | grep include
stream/stream_cdda.c:#include <cdio/cdio.h>

which is not provided by dev-libs/libcdio-paranoia. Now you could argue that dev-libs/libcdio-paranoia will always depend on dev-libs/libcdio in the future, but do we know?

It's similar to cairo and gtk+.
Comment 6 Nikoli 2014-04-06 16:04:34 UTC
When something is used explicitly, we usually add it to deps, but maintainer of cdio packages suggested other deps for some reason.

Samuli, what is your opinion?
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2014-04-07 18:09:30 UTC
(In reply to Nikoli from comment #6)
> When something is used explicitly, we usually add it to deps, but maintainer
> of cdio packages suggested other deps for some reason.
> 
> Samuli, what is your opinion?

The point of the Tracker was to convert packages explicitely using libcdio-paranoia from libcdio
Also since we have the newer libs stable, and the older versions have been removed from tree, the dependency syntax suggested there doesn't make sense anymore

This is to be handled like normal now, so package using dev-libs/libcdio-paranoia, will depend on it. Package using dev-libs/libcdio, will depend on it. Package using both, will depend on both.
Comment 8 Samuli Suominen (RETIRED) gentoo-dev 2014-04-07 18:12:32 UTC
dep adjusted for 0.3.7 and 9999 in tree
Comment 9 Julian Ospald 2014-04-07 18:38:07 UTC
thanks