Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 506718 - app-i18n/ibus-cangjie-2.1 - The IBus engine for users of the Cangjie and Quick input method
Summary: app-i18n/ibus-cangjie-2.1 - The IBus engine for users of the Cangjie and Quic...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: CJK Team
URL: https://github.com/Cangjians/ibus-can...
Whiteboard:
Keywords: EBUILD
Depends on: 506720 506722
Blocks:
  Show dependency tree
 
Reported: 2014-04-04 02:08 UTC by Brendan Horan
Modified: 2014-04-24 05:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ibus-cangjie-2.1-r0.ebuild (ibus-cangjie-2.1-r0.ebuild,553 bytes, text/plain)
2014-04-04 02:10 UTC, Brendan Horan
Details
ibus-cangjie-2.1-r0.ebuild (ibus-cangjie-2.1-r0.ebuild,535 bytes, text/plain)
2014-04-04 08:36 UTC, Brendan Horan
Details
ibus-cangjie-2.1.ebuild (ibus-cangjie-2.1.ebuild,456 bytes, text/plain)
2014-04-05 06:40 UTC, Brendan Horan
Details
ibus-cangjie-2.1.ebuild (ibus-cangjie-2.1.ebuild,469 bytes, text/plain)
2014-04-06 07:58 UTC, Brendan Horan
Details
ibus-cangjie-2.1.ebuild (ibus-cangjie-2.1.ebuild,537 bytes, text/plain)
2014-04-07 01:23 UTC, Brendan Horan
Details
ibus-cangjie-2.1.ebuild (ibus-cangjie-2.1.ebuild,642 bytes, text/plain)
2014-04-09 13:38 UTC, Brendan Horan
Details
ibus-cangjie-2.1.ebuild (ibus-cangjie-2.1.ebuild,905 bytes, text/plain)
2014-04-17 03:27 UTC, Brendan Horan
Details
ibus-cangjie-2.1.ebuild (ibus-cangjie-2.1.ebuild,941 bytes, text/plain)
2014-04-18 08:09 UTC, Brendan Horan
Details
ibus-cangjie-2.1.ebuild (ibus-cangjie-2.1.ebuild,1.02 KB, text/plain)
2014-04-24 00:55 UTC, Brendan Horan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Horan 2014-04-04 02:08:43 UTC
Hi,

Please find attached the first ebuild for ibus-cangjie-2.1-r0.ebuild.

This is an IBus engine for users of the Cangjie and Quick input methods.
It is primarily intended to Hong Kong people who want to input Traditional Chinese, as they are (by far) the majority of Cangjie and Quick users.
However, it should work for others as well (e.g to input Simplified Chinese).
Note that the actual input logic is handled by libcangjie.

I am suggesting "app-i18n/ibus-cangjie"

This ebuild depends on the following :
 * dependency graph for app-i18n/ibus-cangjie-2.1-r0
 `--  app-i18n/ibus-cangjie-2.1-r0  unknown 
   `--  app-i18n/libcangjie-1.1-r0  (app-i18n/libcangjie) unknown 
   `--  app-i18n/ibus-1.5.5  (app-i18n/ibus) amd64 
   `--  dev-python/cangjie-1.1-r0  (dev-python/cangjie) unknown

I will submit additional ebuilds for :
* app-i18n/libcangjie
* dev-python/cangjie

Thanks
Brendan
Comment 1 Brendan Horan 2014-04-04 02:10:00 UTC
Created attachment 374216 [details]
ibus-cangjie-2.1-r0.ebuild
Comment 2 Brendan Horan 2014-04-04 02:10:41 UTC
This ebuild depends on :
 * dependency graph for app-i18n/ibus-cangjie-2.1-r0
 `--  app-i18n/ibus-cangjie-2.1-r0  unknown 
   `--  app-i18n/libcangjie-1.1-r0  (app-i18n/libcangjie) unknown 
   `--  app-i18n/ibus-1.5.5  (app-i18n/ibus) amd64 
   `--  dev-python/cangjie-1.1-r0  (dev-python/cangjie) unknown
Comment 3 Brendan Horan 2014-04-04 02:26:10 UTC
This input method is different from "app-i18n/ibus-table-chinese".

ibus-cangjie is aimed mostly at users in Hong Kong where as "app-i18n/ibus-table-chinese" aims to cover a large range of Chinese inputs.
Comment 4 Brendan Horan 2014-04-04 08:36:35 UTC
Created attachment 374228 [details]
ibus-cangjie-2.1-r0.ebuild

Updated ebuild to pass repoman.
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2014-04-05 00:31:44 UTC
Comment on attachment 374228 [details]
ibus-cangjie-2.1-r0.ebuild

These are defaults and should be removed:

>src_configure() {
>		econf
>}
>
>src_install() {
>		emake DESTDIR="${D}" install
>}
Comment 6 Brendan Horan 2014-04-05 06:40:46 UTC
Created attachment 374282 [details]
ibus-cangjie-2.1.ebuild

Removed default sections.
added new ebuild
Repoman passed
Comment 7 Brendan Horan 2014-04-05 06:49:44 UTC
I am also able to maintain this package.
Comment 8 Brendan Horan 2014-04-06 07:58:03 UTC
Created attachment 374364 [details]
ibus-cangjie-2.1.ebuild

Fixed Licence.
Fixed homepage.
Fixed licence.
Added new ebuild.
Comment 9 Naohiro Aota gentoo-dev 2014-04-07 00:14:34 UTC
No RDEPEND?
Comment 10 Brendan Horan 2014-04-07 01:23:38 UTC
Created attachment 374436 [details]
ibus-cangjie-2.1.ebuild

Added RDEPEND to ebuild.
Comment 11 Brendan Horan 2014-04-07 01:26:52 UTC
I have checked this via repoman, equery and a full emerge of the package.
Will email proxy maintainers as well.
Comment 12 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2014-04-09 10:15:47 UTC
(In reply to Brendan Horan from comment #10)
> Created attachment 374436 [details]
> ibus-cangjie-2.1.ebuild
> 
> Added RDEPEND to ebuild.

1. You specify a PYTHON variable but inherit no eclass; please inherit an eclass and migrate to the new Python eclasses, see for reference https://wiki.gentoo.org/wiki/Project:Python/Eclasses

   See `man 5 ebuild` for more information about inherit.

2. There are missing dependencies that can be deduced from configure.ac: dev-util/intltool in DEPEND, sys-devel/gettext in DEPEND, virtual/libintl in RDEPEND

3. There is a version range missing that can be deduced from configure.ac; ibus has to be at least 1.4.1, can be specified as >=app-i18n/ibus-1.4.1

4. If DEPEND and RDEPEND are the same, you can use DEPEND="${RDEPEND}"

5. Variables like KEYWORDS, DEPEND, RDEPEND, etc.. can be sorted for consistency.

If you need help, feel free to let us know.
Comment 13 Brendan Horan 2014-04-09 13:38:55 UTC
Created attachment 374600 [details]
ibus-cangjie-2.1.ebuild

In reply to comment 12 :

1)
Corrected inherits.
Corrected python eclasses.

2)
Reexamined the configure.ac and added in dependencies.

3)
Version range for ibus has been added.

4)
They are not the same now. However thanks for the tip :)

5)
Variables have been sorted.

I have attached a new ebuild to correct all of the above issues.
Comment 14 Naohiro Aota gentoo-dev 2014-04-17 00:42:25 UTC
Comment on attachment 374600 [details]
ibus-cangjie-2.1.ebuild

>DEPEND=">=app-i18n/ibus-1.4.1
>		app-i18n/libcangjie
>		dev-python/cangjie

Please take a look at PYTHON_USEDEP from python-r1.eclass

>		dev-util/intltool
>		sys-devel/gettext"

This ebuild also need to be improved to support multiple python version as dev-python/cangjie do.
Comment 15 Brendan Horan 2014-04-17 03:27:58 UTC
Created attachment 375116 [details]
ibus-cangjie-2.1.ebuild

In reply to comment 14

Fixed "PYTHON_USEDEP" issues.
Fixed multiple python version support.
Comment 16 Naohiro Aota gentoo-dev 2014-04-18 00:05:14 UTC
(In reply to Brendan Horan from comment #15)
> Created attachment 375116 [details]
> ibus-cangjie-2.1.ebuild
> 
> In reply to comment 14
> 
> Fixed "PYTHON_USEDEP" issues.

It seems it still lack PYTHON_USEDEP usage. PYTHON_USEDEP is used to pull dependending package with same PYTHON_TARGETS. Please check PYTHON_USEDEP usage from python-r1.eclass
Comment 17 Brendan Horan 2014-04-18 08:09:19 UTC
Created attachment 375174 [details]
ibus-cangjie-2.1.ebuild

Added PYTHON_USEDEP
I hope that is the correct usage of this.
Comment 18 Naohiro Aota gentoo-dev 2014-04-23 09:05:55 UTC
(In reply to Brendan Horan from comment #17)
> Created attachment 375174 [details]
> ibus-cangjie-2.1.ebuild
> 
> Added PYTHON_USEDEP
> I hope that is the correct usage of this.

You may also need to use gnome2_icon_{savelist,cache_update} from gnome2-utils.eclass so that /usr/share/icons/hicolor/icon-theme.cache is updated after the install.
Comment 19 Brendan Horan 2014-04-24 00:55:22 UTC
Created attachment 375572 [details]
ibus-cangjie-2.1.ebuild

Added "gnome2_icon_savelist" and "gnome2_icon_cache_update".

Updates the cache now :
 * Updating icons cache ...   [ ok ]


# ls -la /usr/share/icons/hicolor/icon-theme.cache
-rw-r--r-- 1 root root 26911824 Apr 24 08:51 /usr/share/icons/hicolor/icon-theme.cache
# date
Thu Apr 24 08:52:03 HKT 2014

Attached new ebuild.
Comment 20 Naohiro Aota gentoo-dev 2014-04-24 05:08:51 UTC
Now it get in to the tree! Thank you for the work!