Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 506638 - x11-misc/spacefm-0.9.3 - re-add gtk2 support
Summary: x11-misc/spacefm-0.9.3 - re-add gtk2 support
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Julian Ospald
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-04-03 06:29 UTC by zlg (RETIRED)
Modified: 2014-04-04 18:41 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Diff for spacefm-0.9.3.ebuild (file_506638.txt,540 bytes, text/plain)
2014-04-03 06:29 UTC, zlg (RETIRED)
Details
Unified diff for spacefm-0.9.3.ebuild (file_506638.txt,970 bytes, patch)
2014-04-03 07:40 UTC, zlg (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zlg (RETIRED) gentoo-dev 2014-04-03 06:29:51 UTC
Created attachment 374138 [details]
Diff for spacefm-0.9.3.ebuild

SpaceFM has support for both GTK2 and GTK3 in its build system. The project developer has mentioned that this may not always be this way [1], but for now it supports both. This should be reflected in a USE flag of some sort.

I took a stab at implementing a `gtk2` USE flag, but repoman complains about it not being in use.desc. I'm not sure what the correct way to proceed (or implement the USE flag) is, but I wanted to show that there is user interest in SpaceFM retaining gtk2 support and I personally attempted to implement it.

Thanks for your time and consideration.

[1]: http://igurublog.wordpress.com/2014/03/22/gtk-3-10-drops-menu-icons-and-mnemonics/
 ¶ 11: "At some point, I believe I may need to drop GTK3 support entirely from SpaceFM, but we haven’t reached that point yet."
Comment 1 zlg (RETIRED) gentoo-dev 2014-04-03 07:40:32 UTC
Created attachment 374140 [details, diff]
Unified diff for spacefm-0.9.3.ebuild

Updated patch to be unified as per recommendation from another user.
Comment 2 Rafał Mużyło 2014-04-03 08:26:11 UTC
> [1]: http://igurublog.wordpress.com/2014/03/22/gtk-3-10-drops-menu-icons and-mnemonics/
> ¶ 11: "At some point, I believe I may need to drop GTK3 support entirely from SpaceFM, but we haven’t reached that point yet."

Well, gtk3 devs *are* being stupid about quite a few topics.
Yet, unless upstream *actually* drops the support, this 'problem' has already been dealt with in bug 489810.
Comment 3 zlg (RETIRED) gentoo-dev 2014-04-03 08:45:07 UTC
(In reply to Rafał Mużyło from comment #2)
> > [1]: http://igurublog.wordpress.com/2014/03/22/gtk-3-10-drops-menu-icons and-mnemonics/
> > ¶ 11: "At some point, I believe I may need to drop GTK3 support entirely from SpaceFM, but we haven’t reached that point yet."
> 
> Well, gtk3 devs *are* being stupid about quite a few topics.
> Yet, unless upstream *actually* drops the support, this 'problem' has
> already been dealt with in bug 489810.

Wow. This seems odd. If the maintainer refuses to support choice, then is my only option to maintain my own version of the ebuild(s) in a local overlay? This seems like a step backwards...
Comment 4 Julian Ospald 2014-04-03 18:50:56 UTC
It was a decision, also see bug #420493.

Move on, don't fight the gtk+-3 train.
Comment 5 Julian Ospald 2014-04-03 18:57:38 UTC
(In reply to Daniel Campbell from comment #3)
> (In reply to Rafał Mużyło from comment #2181)
> > > [1]: http://igurublog.wordpress.com/2014/03/22/gtk-3-10-drops-menu-icons182 and-mnemonics/
> > > ¶ 11: "At some point, I believe I may need to drop GTK3 support entirely from SpaceFM, but we haven’t reached that point yet."
> > 
> > Well, gtk3 devs *are* being stupid about quite a few topics.
> > Yet, unless upstream *actually* drops the support, this 'problem' has
> > already been dealt with in bug 489810183.
> 
> Wow. This seems odd. If the maintainer refuses to support choice, then is my
> only option to maintain my own version of the ebuild(s) in a local overlay?
> This seems like a step backwards...

USE flags were never meant to pass all possible configure-switches in the world to the end user. We pick USE flags from a number of considerations. This use case is not supported and that's what the gnome team advises. gtk+-3 is in stable arch.
Comment 6 zlg (RETIRED) gentoo-dev 2014-04-03 20:57:33 UTC
(In reply to Julian Ospald (hasufell) from comment #5)
> (In reply to Daniel Campbell from comment #3)
> > (In reply to Rafał Mużyło from comment #2181)
> > > > [1]: http://igurublog.wordpress.com/2014/03/22/gtk-3-10-drops-menu-icons182 and-mnemonics/
> > > > ¶ 11: "At some point, I believe I may need to drop GTK3 support entirely from SpaceFM, but we haven’t reached that point yet."
> > > 
> > > Well, gtk3 devs *are* being stupid about quite a few topics.
> > > Yet, unless upstream *actually* drops the support, this 'problem' has
> > > already been dealt with in bug 489810183.
> > 
> > Wow. This seems odd. If the maintainer refuses to support choice, then is my
> > only option to maintain my own version of the ebuild(s) in a local overlay?
> > This seems like a step backwards...
> 
> USE flags were never meant to pass all possible configure-switches in the
> world to the end user. We pick USE flags from a number of considerations.
> This use case is not supported and that's what the gnome team advises.
> gtk+-3 is in stable arch.

Thanks for the clarification and transparency.

In your other comment you told me "don't fight the GTK 3 train." Do you agree with Gentoo's GNOME team's stance to only support GTK 3 moving forward, or were there many discussions had that they simply wouldn't move on? I ask this because upstream GNOME developers are known for disregarding legitimate user concerns and requests, and downstream GNOME maintainers seem to adopt the same attitude.

To clarify, my intent isn't to fight, but to understand so I can decide what I will do as a user. Is this something the Council has voted on?
Comment 7 Julian Ospald 2014-04-04 18:13:44 UTC
(In reply to Daniel Campbell from comment #6)
> (In reply to Julian Ospald (hasufell) from comment #5200)
> > (In reply to Daniel Campbell from comment #3201)
> > > (In reply to Rafał Mużyło from comment #2181202)
> > > > > [1]: http://igurublog.wordpress.com/2014/03/22/gtk-3-10-drops-menu-icons182203 and-mnemonics/
> > > > > ¶ 11: "At some point, I believe I may need to drop GTK3 support entirely from SpaceFM, but we haven’t reached that point yet."
> > > > 
> > > > Well, gtk3 devs *are* being stupid about quite a few topics.
> > > > Yet, unless upstream *actually* drops the support, this 'problem' has
> > > > already been dealt with in bug 489810183.
> > > 
> > > Wow. This seems odd. If the maintainer refuses to support choice, then is my
> > > only option to maintain my own version of the ebuild(s) in a local overlay?
> > > This seems like a step backwards...
> > 
> > USE flags were never meant to pass all possible configure-switches in the
> > world to the end user. We pick USE flags from a number of considerations.
> > This use case is not supported and that's what the gnome team advises.
> > gtk+-3 is in stable arch.
> 
> Thanks for the clarification and transparency.
> 
> In your other comment you told me "don't fight the GTK 3 train." Do you
> agree with Gentoo's GNOME team's stance to only support GTK 3 moving
> forward, or were there many discussions had that they simply wouldn't move
> on? I ask this because upstream GNOME developers are known for disregarding
> legitimate user concerns and requests, and downstream GNOME maintainers seem
> to adopt the same attitude.
> 
> To clarify, my intent isn't to fight, but to understand so I can decide what
> I will do as a user. Is this something the Council has voted on?

That is nothing the council has to decide on. I can decide that for my own packages. However, there was disagreement about the naming of gtk USE flags and there still is confusion about it, including QA not communicating properly with the affected library maintainers, council not making any decision... the usual stuff.

Anyway, I don't want to support different set of bugs and I doubt that spacefm upstream will care too much about non-trivial gtk+2 related bugs anymore. I do some gtk+ development myself, so I know that the codepaths can diverge a lot.
Comment 8 Rafał Mużyło 2014-04-04 18:30:43 UTC
@comment 7:
I think the very problem here is that the upstream (due to some dumb moves on gtk+ upstream side) is considering taking a step back and dropping gtk3 in favor of gtk2.
Comment 9 Julian Ospald 2014-04-04 18:41:51 UTC
(In reply to Rafał Mużyło from comment #8)
> @comment 7218:
> I think the very problem here is that the upstream (due to some dumb moves
> on gtk+ upstream side) is considering taking a step back and dropping gtk3
> in favor of gtk2.

In that case the whole ebuild will be reverted to gtk+2, obviously.