Bug 506472 – =sys-devel/llvm-3.4-r1 - /tmp own by package

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Bertrand Jacquin 2014-04-01 16:01:11 UTC]

# emerge -pv =sys-devel/llvm-3.4
(...)
[ebuild   R    ] sys-devel/llvm-3.4:0/3.4  USE="clang libffi ncurses static-analyzer -debug -doc -gold -multitarget -ocaml -python {-test} -udis86 -xml" ABI_X86="(64) -32 (-x32)" PYTHON_TARGETS="python2_7 -pypy -pypy2_0 -python2_6" VIDEO_CARDS="-radeon" 0 kB

# qfile -v /tmp
sys-devel/llvm-3.4 (/tmp)

# grep -E '^(\S+) /tmp' /var/db/pkg/sys-devel/llvm-3.4/CONTENTS
dir /tmp

So no files are provided by sys-devel/llvm

Reproducible: Always

[Comment 1 Alex Xu (Hello71) 2014-04-01 23:34:00 UTC]

Please paste emerge --info =sys-devel/llvm-3.4.

[Comment 2 Bertrand Jacquin 2014-04-02 14:20:06 UTC]

Created attachment 374094 [details]
emerge --info

[Comment 3 Jeroen Roovers (RETIRED) 2014-04-02 14:47:43 UTC]

This seems to have been fixed in CVS revision 1.10 of llvm-3.4.ebuild:

@@ -387,25 +391,15 @@
        local MAKEARGS
        set_makeargs
 
-       emake "${MAKEARGS[@]}" DESTDIR="${D}" install
+       local root=${D}/_${ABI}
 
-       # Preserve ABI-variant of llvm-config.
-       dodir /tmp
-       mv "${ED}"/usr/bin/llvm-config "${ED}"/tmp/"${CHOST}"-llvm-config || die
+       emake "${MAKEARGS[@]}" DESTDIR="${root}" install
+       multibuild_merge_root "${root}" "${D}"
 
        if ! multilib_build_binaries; then
-               # Drop all the executables since LLVM doesn't like to
-               # clobber when installing.
-               rm -r "${ED}"/usr/bin || die
-
                # Backwards compat, will be happily removed someday.
-               dosym "${CHOST}"-llvm-config /tmp/llvm-config.${ABI}
+               dosym "${CHOST}"-llvm-config /usr/bin/llvm-config.${ABI}
        else
-               # Move files back.
-               mv "${ED}"/tmp/*llvm-config* "${ED}"/usr/bin || die
-               # Create a symlink for host's llvm-config.
-               dosym "${CHOST}"-llvm-config /usr/bin/llvm-config
-
                # Install docs.
                if use doc; then
                        doman "${S}"/docs/_build/man/*.1

[Comment 4 Bertrand Jacquin 2014-04-04 18:13:33 UTC]

(In reply to Jeroen Roovers from comment #3)
> This seems to have been fixed in CVS revision 1.10 of llvm-3.4.ebuild:
> 
> @@ -387,25 +391,15 @@
>         local MAKEARGS
>         set_makeargs
>  
> -       emake "${MAKEARGS[@]}" DESTDIR="${D}" install
> +       local root=${D}/_${ABI}
>  
> -       # Preserve ABI-variant of llvm-config.
> -       dodir /tmp
> -       mv "${ED}"/usr/bin/llvm-config "${ED}"/tmp/"${CHOST}"-llvm-config ||
> die
> +       emake "${MAKEARGS[@]}" DESTDIR="${root}" install
> +       multibuild_merge_root "${root}" "${D}"
>  
>         if ! multilib_build_binaries; then
> -               # Drop all the executables since LLVM doesn't like to
> -               # clobber when installing.
> -               rm -r "${ED}"/usr/bin || die
> -
>                 # Backwards compat, will be happily removed someday.
> -               dosym "${CHOST}"-llvm-config /tmp/llvm-config.${ABI}
> +               dosym "${CHOST}"-llvm-config /usr/bin/llvm-config.${ABI}
>         else
> -               # Move files back.
> -               mv "${ED}"/tmp/*llvm-config* "${ED}"/usr/bin || die
> -               # Create a symlink for host's llvm-config.
> -               dosym "${CHOST}"-llvm-config /usr/bin/llvm-config
> -
>                 # Install docs.
>                 if use doc; then
>                         doman "${S}"/docs/_build/man/*.1

This does not the fix this in sys-devel/llvm-3.4-r1

# qfile -v /tmp
sys-devel/llvm-3.4-r1 (/tmp)

[Comment 5 Michał Górny 2014-04-10 20:55:29 UTC]

This is now in -3.4-r2, p.masked for now. See bug #506398.

[Comment 6 Bertrand Jacquin 2014-05-20 22:15:56 UTC]

(In reply to Michał Górny from comment #5)
> This is now in -3.4-r2, p.masked for now. See bug #506398.

Unmasked with 3.4.1-r1 if I'm right. Here it's ok now. Maybe we can close ?

[Comment 7 Michał Górny 2014-05-21 07:33:33 UTC]

Oh, yes :).