Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 50636 - darcnes-0401-r1 forces dependency on svgalib
Summary: darcnes-0401-r1 forces dependency on svgalib
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-10 08:02 UTC by Alexandru Toma
Modified: 2004-05-10 18:03 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
darcnes-0401-r1.ebuild.patch (darcnes-0401-r1.ebuild.patch,1.85 KB, patch)
2004-05-10 09:01 UTC, Sven Wegener
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Toma 2004-05-10 08:02:21 UTC
Darcnes doesn't use the svga? ( ) syntax for the media-libs/svgalib-1.4.2 dependency.

I think this can easily be fixed by adding a if [ "`use svga`" ]around
cat Makefile.orig | sed "s:^TARGET?=Linux_X$:TARGET?=Linux_svgalib:" \
> Makefile
make || die

and around
doexe sdarcnes

and by modiffying the IUSE and DEPEND sections accordingly

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Sven Wegener gentoo-dev 2004-05-10 09:01:14 UTC
Created attachment 31112 [details, diff]
darcnes-0401-r1.ebuild.patch

i gave this one a little update.

- using games.eclass
- removed the replacing of CDROM_DEVICE because i don't think that we should
  force /dev/cdroms/cdrom0 as it, /dev/cdrom is more useable in my opinion.
  this way the user can have a symlink to his favourite device
- uses CFLAGS for optimizing
- svgalib is now optional, not a requirement
- removed sed scripts with some nice make TARGET=
Comment 2 Mr. Bones. (RETIRED) gentoo-dev 2004-05-10 12:02:33 UTC
Added to CVS.  Thanks for the bug report and patch.
Comment 3 Sven Wegener gentoo-dev 2004-05-10 12:56:58 UTC
now we're having an unconditional dependency on virtual/x11. the advantage
of svgalib (having graphics on terminals without X installed) is lost in this
package.
Comment 4 Mr. Bones. (RETIRED) gentoo-dev 2004-05-10 14:40:26 UTC
Right, sorry about that.  I always forget about what people are after with svgalib since I don't use it.  Fixed it up in CVS.
Comment 5 Sven Wegener gentoo-dev 2004-05-10 17:14:49 UTC
sry, but i need to add another note here. now when merging with
USE="-svga -X -gtk" the ebuild will only install the readme.
would be nice if we'll get an error message then ;)
Comment 6 Mr. Bones. (RETIRED) gentoo-dev 2004-05-10 18:03:48 UTC
take 2.