Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 50635 - lm-sensors-2.6.5 (last one which can be installed without patching kernel) can't be compiled
Summary: lm-sensors-2.6.5 (last one which can be installed without patching kernel) ca...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Tim Yamin (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-10 06:55 UTC by Honza
Modified: 2004-07-12 08:28 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Repair long strings (lm-sensors-2.6.5-hk-longstring.patch,1.44 KB, patch)
2004-06-01 08:49 UTC, Honza 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Honza 2004-05-10 06:55:24 UTC 
lm-sensors-2.6.5 (last one which can be installed without patching kernel) can't be compiled. Problem is in strings used as arguments for MODULE_AUTHOR macro - they in some cases contain newline.

Reproducible: Always
Steps to Reproduce:
1. emerge =lm-sensors-2.6.5


Actual Results:  
Nothing.

Expected Results:  
Install lm-sensors.

One way to repair that strings (I hope this bugzilla don't split lines):

diff -ruN lm_sensors-2.6.5.orig/kernel/busses/i2c-ali1535.c
lm_sensors-2.6.5/kernel/busses/i2c-ali1535.c                           
--- lm_sensors-2.6.5.orig/kernel/busses/i2c-ali1535.c   2002-06-08
21:49:06.000000000 +0200                                        
+++ lm_sensors-2.6.5/kernel/busses/i2c-ali1535.c        2004-05-08
20:13:32.000000000 +0200                                        
@@ -672,8 +672,7 @@                                                            
                                                   
 #ifdef MODULE                                                                 
                                                   
                                                                               
                                                   
 MODULE_AUTHOR                                                                 
                                                   
-    ("Frodo Looijaard <frodol@dds.nl>, Philip Edelbrock <phil@netroedge.com>, 
                                                   
-      Mark D. Studebaker <mdsxyz123@yahoo.com> and Dan Eaton
<dan.eaton@rocketlogix.com>");                                       
+    ("Frodo Looijaard <frodol@dds.nl>, Philip Edelbrock <phil@netroedge.com>,
Mark D. Studebaker <mdsxyz123@yahoo.com> and Dan Eat
on <dan.eaton@rocketlogix.com>");                                              
                                                   
 MODULE_DESCRIPTION("ALI1535 SMBus driver");                                   
                                                   
                                                                               
                                                   
 int init_module(void)                                                         
                                                   
diff -ruN lm_sensors-2.6.5.orig/kernel/chips/lm87.c
lm_sensors-2.6.5/kernel/chips/lm87.c                                           
--- lm_sensors-2.6.5.orig/kernel/chips/lm87.c   2002-02-09 23:36:26.000000000
+0100                                                
+++ lm_sensors-2.6.5/kernel/chips/lm87.c        2004-05-08 20:20:14.000000000
+0200                                                
@@ -1060,10 +1060,10 @@                                                        
                                                   
 #endif                                                                        
                                                   
                                                                               
                                                   
 MODULE_AUTHOR                                                                 
                                                   
-    ("Frodo Looijaard <frodol@dds.nl>,                                        
                                                   
-      Philip Edelbrock <phil@netroedge.com>,                                  
                                                   
-      Mark Studebaker <mdsxyz123@yahoo.com>,                                  
                                                   
-      and Stephen Rousset <stephen.rousset@rocketlogix.com>");                
                                                   
+    ("Frodo Looijaard <frodol@dds.nl>, "                                      
                                                   
+     "Philip Edelbrock <phil@netroedge.com>, "                                
                                                   
+     "Mark Studebaker <mdsxyz123@yahoo.com>, "                                
                                                   
+     "and Stephen Rousset <stephen.rousset@rocketlogix.com>");                
                                                   
                                                                               
                                                   
 MODULE_DESCRIPTION("LM87 driver");
Comment 1 Honza 2004-05-10 06:58:51 UTC 
OK, either bugzilla or my copy&paste splited lines. I hope you can repair it. It's not so complex patch.
Comment 2 Tim Yamin (RETIRED) gentoo-dev 2004-06-01 04:37:19 UTC 
Would you mind attaching the patch to this bug since Bugzilla sometimes turns embedded tabs to spaces? Thanks...
Comment 3 Honza 2004-06-01 08:49:32 UTC 
Created attachment 32464 [details, diff]
Repair long strings

Of course, attaching patch is better that copy&paste ... I didn't notice this
posibility before.
Comment 4 Greg Kroah-Hartman (RETIRED) gentoo-dev 2004-06-21 13:58:04 UTC 
Not a kernel issue, please reassign to lm-sensors people.
Comment 5 Tim Yamin (RETIRED) gentoo-dev 2004-07-12 08:28:18 UTC 
Now in CVS; the change should reach Portage within an hour. Thanks!