Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 50633 - Under fvwm2, mplayer failed to return to proper size after fullscreen
Summary: Under fvwm2, mplayer failed to return to proper size after fullscreen
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-10 06:49 UTC by Honza
Modified: 2004-11-10 17:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Honza 2004-05-10 06:49:54 UTC
Under fvwm2 (x11-wm/fvwm-2.5.8-r6), mplayer (media-video/mplayer-1.0_pre4) failed to return to proper size after fullscreen. Instead of returning to original size, window is set to maximal width                                                               and keep aspect ratio.

I traced problem to change in vo_x11_sizehint.                                                                                     
In 0.92, mplayer didn't set vo_hint.flags |= PMinSize and it work fine.                                                            
In 1.0,  mplayer did set vo_hint.flags |= PMinSize and this is result.                                                             
                                                                                                                                   
I don't know if error is in fvwm, mplayer or both, but for me return to                                                            
original mplayer behavior works.                                                                                                   


Reproducible: Always
Steps to Reproduce:
1. run X with fvwm as window manager
2. run mplayer on film smaller that desktop without zoom
3. toggle it fullscreen
4. toggle it back

Actual Results:  
mplayer window is set to maximal width and keep aspect ratio.

Expected Results:  
mplayer window should have same size as before fullscreen.

Return to original behavior:

--- libvo/x11_common.c  2004-04-05 23:35:30.000000000 +0200                    
                                                   
+++ libvo/x11_common.c.new      2004-05-08 18:32:06.000000000 +0200            
                                                   
@@ -844,7 +844,7 @@ void vo_x11_sizehint( int x, int y, int                    
                                                   
  // set min height/width to 4 to avoid off by one errors                      
                                                   
  // and because mga_vid requires a minial size of 4 pixel                     
                                                   
  vo_hint.min_width = vo_hint.min_height = 4;                                  
                                                   
- vo_hint.flags |= PMinSize;                                                   
                                                   
+/* vo_hint.flags |= PMinSize;*//* HK: let's don't ... */                      
                                                   
                                                                               
                                                   
  vo_hint.win_gravity=StaticGravity;                                           
                                                   
  XSetWMNormalHints( mDisplay,vo_window,&vo_hint );
Comment 1 Brian Harring (RETIRED) gentoo-dev 2004-06-25 12:19:01 UTC
Please try out the patch in #43010- the sooner the better (the 1.0_pre* patch is slated for inclussion soon).
Comment 2 Tavis Ormandy (RETIRED) gentoo-dev 2004-06-25 15:18:39 UTC
There was a mention of this on the fvwm mailing list about a week ago, IIRC, there is some ambiguity in the standards, and the mplayer guys changed their mind about what it meant. I think the conclusion was there is room for both interpretations and a patch was committed..so the next version of fvwm will interact with the new mplayer correctly.
Comment 3 Chris White (RETIRED) gentoo-dev 2004-11-10 17:47:13 UTC
fvwm is at 2.5.12 right now, so I'm closing this bug since it was stated that MPlayer would correctly interact with fvwm.  If this is not the case, please re-open the bug.