505596 – net-im/jabberd2 postrotate script uses wrong pidfiles

Bug 505596 - net-im/jabberd2 postrotate script uses wrong pidfiles

Summary: net-im/jabberd2 postrotate script uses wrong pidfiles

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Server (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Julian Ospald

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2014-03-25 07:28 UTC by Dmitry A. Bakshaev
Modified:	2014-06-02 09:47 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
add "reload" option to jabberd2-2.3.1.init (jabberd2-2.3.1.init.diff,833 bytes, patch) 2014-03-25 07:28 UTC, Dmitry A. Bakshaev	Details \| Diff
logrotate with "/etc/init.d/jabberd reload" (jabberd2-2.3.1.logrotate.diff,537 bytes, patch) 2014-03-25 07:29 UTC, Dmitry A. Bakshaev	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dmitry A. Bakshaev 2014-03-25 07:28:03 UTC

jabberd pidfiles has a "jabberd-" prefix:
grep pid /etc/jabber/*.dist
/etc/jabber/c2s.xml.dist:  <pidfile>/var/run/jabber/jabberd2-c2s.pid</pidfile>
/etc/jabber/router.xml.dist:  <pidfile>/var/run/jabber/jabberd2-router.pid</pidfile>
/etc/jabber/s2s.xml.dist:  <pidfile>/var/run/jabber/jabberd2-s2s.pid</pidfile>
/etc/jabber/sm.xml.dist:  <pidfile>/var/run/jabber/jabberd2-sm.pid</pidfile>

but in jabberd2-2.3.1.logrotate postrotate script:
        kill -HUP $(cat /var/run/jabberd/c2s.pid)
        kill -HUP $(cat /var/run/jabberd/s2s.pid)
        kill -HUP $(cat /var/run/jabberd/sm.pid)
        kill -HUP $(cat /var/run/jabberd/router.pid)

Comment 1 Dmitry A. Bakshaev 2014-03-25 07:28:38 UTC

Created attachment 373478 [details, diff]
add "reload" option to jabberd2-2.3.1.init

Comment 2 Dmitry A. Bakshaev 2014-03-25 07:29:07 UTC

Created attachment 373480 [details, diff]
logrotate with "/etc/init.d/jabberd reload"

Comment 3 parafin 2014-04-02 20:55:06 UTC

Also I think "missingok" option should be added to logrotate because when syslog is used for logging (which seems to be the default) /var/log/jabber/ is empty.

Comment 4 Julian Ospald 2014-04-22 19:15:03 UTC

do you think this is worth a revbump?

Comment 5 Julian Ospald 2014-06-01 20:10:10 UTC

+*jabberd2-2.3.2-r1 (01 Jun 2014)
+
+  01 Jun 2014; Julian Ospald <hasufell@gentoo.org> +jabberd2-2.3.2-r1.ebuild,
+  +files/jabberd2-2.3.2.init, +files/jabberd2-2.3.2.logrotate:
+  fix logroate script wrt #505596

Comment 6 parafin 2014-06-02 09:47:29 UTC

What about missingok option?