Bug 505104 – sys-cluster/neutron-2013.2.1 - /etc/init.d/neutron-* fail to start when certain configuration files are not found?

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Davide Rebeccani 2014-03-19 17:49:37 UTC]

sys-cluster/neutron-2013.2.1 ebuild has broken init scrips for neutron agents

Reproducible: Always

Steps to Reproduce:
1.emerge =sys-cluster/neutron-2013.2.1
2./etc/init.d/neutron-dhcp-agent start
3.
Actual Results:  
neutron-dhcp-agent doesn't start

Expected Results:  
neutron-dhcp-agent runs as expected

I alas added some entries in /etc/conf.d/neutron to track agent's config files, leaving an Openstack admin to chose which config files to pass to the agent binary

[Comment 1 Davide Rebeccani 2014-03-19 17:51:22 UTC]

Created attachment 373042 [details]
Fixed sys-cluster/neutron-2013.2.1 ebuild

[Comment 2 Davide Rebeccani 2014-03-19 17:51:53 UTC]

Created attachment 373044 [details]
Fixed sys-cluster/neutron confd file

[Comment 3 Davide Rebeccani 2014-03-19 17:52:22 UTC]

Created attachment 373048 [details]
Fixed sys-cluster/neutron-2013.2.1 init script

[Comment 4 Davide Rebeccani 2014-03-19 21:55:12 UTC]

Sorry. As an instance i used neutron-dhcp-agent, but there's the same problem on the other deamons

[Comment 5 Jeroen Roovers (RETIRED) 2014-03-20 14:48:12 UTC]

Comment on attachment 373042 [details]
Fixed sys-cluster/neutron-2013.2.1 ebuild

--- neutron-2013.2.2.ebuild     2014-02-20 22:10:50.000000000 +0100
+++ -   2014-03-20 15:47:39.682981021 +0100
@@ -136,6 +136,7 @@
        doins "etc/policy.json"
        doins "etc/neutron.conf"
        doins "etc/rootwrap.conf"
+       doins "etc/metadata_agent.ini"
        insinto /etc
        doins -r "etc/neutron/"

[Comment 6 Jeroen Roovers (RETIRED) 2014-03-20 14:49:07 UTC]

Comment on attachment 373044 [details]
Fixed sys-cluster/neutron confd file

--- files/neutron-confd 2013-09-05 23:46:49.000000000 +0200
+++ -   2014-03-20 15:48:38.758695145 +0100
@@ -1,2 +1,7 @@
 #Don't touch this unless you know what you are doing
-PID_PATH=/run/quantum
+PID_PATH=/run/neutron
+SERVER_CONFIG_FILES=/etc/neutron/plugins/openvswitch/ovs_neutron_plugin.ini
+L3_AGENT_CONFIG_FILES=/etc/neutron/l3_agent.ini 
+DHCP_AGENT_CONFIG_FILES=/etc/neutron/dhcp_agent.ini 
+METADATA_AGENT_CONFIG_FILES=/etc/neutron/metadata_agent.ini 
+PLUGINS_CONFIG_FILES=/etc/neutron/plugins/openvswitch/ovs_neutron_plugin.ini

[Comment 7 Jeroen Roovers (RETIRED) 2014-03-20 14:49:51 UTC]

Comment on attachment 373048 [details]
Fixed sys-cluster/neutron-2013.2.1 init script

--- files/neutron-initd-2       2013-10-23 18:13:26.000000000 +0200
+++ -   2014-03-20 15:49:26.647244313 +0100
@@ -27,6 +27,26 @@
         mkdir ${PID_PATH}
     fi
+    case ${SERVERNAME} in 
+       server)
+               SERVICE_CONFIG_FILES=$SERVER_CONFIG_FILES
+       ;;
+       dhcp)
+               SERVICE_CONFIG_FILES=$DHCP_AGENT_CONFIG_FILES
+       ;;
+       l3)
+               SERVICE_CONFIG_FILES=$L3_AGENT_CONFIG_FILES
+       ;;
+       metadata)
+               SERVICE_CONFIG_FILES=$METADATA_AGENT_CONFIG_FILES
+       ;;
+       openvswitch)
+               SERVICE_CONFIG_FILES=$PLUGINS_CONFIG_FILES
+       ;;
+       *)
+       ;;
+    esac
+
     start-stop-daemon --start \
         --user neutron:neutron \
         --quiet \
@@ -35,8 +55,8 @@
         --background \
         --exec /usr/bin/${SVCNAME} -- \
             --config-file /etc/neutron/neutron.conf \
-            --config-file /etc/neutron/plugins/openvswitch/ovs_neutron_plugin.ini \
-                        --log-file /var/log/neutron/server.log
+            --config-file $SERVICE_CONFIG_FILES \
+                        --log-file "/var/log/neutron/${SERVERNAME}.log"
     eend $? "Failed to start ${SVCNAME}"
 }

[Comment 8 Vadim Kuznetsov (RETIRED) 2014-03-30 16:12:31 UTC]

Created attachment 373904 [details, diff]
new init scripts; permissions of the conf files

[Comment 9 Matthew Thode ( prometheanfire ) 2014-11-26 21:07:03 UTC]

dunno why this is still open, fixed a while ago :D