Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 50432 - patch for YoSucker
Summary: patch for YoSucker
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High major (vote)
Assignee: Abhishek Amit (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-08 00:42 UTC by Jonathan Rogers
Modified: 2004-09-23 02:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch against YoSucker-pr53 (yosucker-53-no-redirect.patch,637 bytes, patch)
2004-05-08 00:45 UTC, Jonathan Rogers
Details | Diff
Ebuild that incorporates patch (yosucker-53-r1.ebuild,1007 bytes, text/plain)
2004-05-08 00:48 UTC, Jonathan Rogers
Details
tweaked ebuild (yosucker-53-r1.ebuild,983 bytes, text/plain)
2004-05-08 21:31 UTC, Jonathan Rogers
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Rogers 2004-05-08 00:42:46 UTC
YoSucker is a program that fetches email messages from a Yahoo Mail account using the web interface. It seems that the Yahoo Mail login process has changed enough to break the current version of YoSucker. So a fix has been presented on the mailing list. There is not likely to be a new version of YoSucker for some time, so here is a slightly modified ebuild which incorporates the suggested change.
Comment 1 Jonathan Rogers 2004-05-08 00:45:51 UTC
Created attachment 30984 [details, diff]
patch against YoSucker-pr53

This patch allows YoSucker to work with the current Yahoo Mail web interface.
Comment 2 Jonathan Rogers 2004-05-08 00:48:33 UTC
Created attachment 30985 [details]
Ebuild that incorporates patch

In addition to applying the necessary patch, this ebuild also puts the
"header-translation" file in a stable location (/usr/share/yosucker) to allow
easier user configuration.
Comment 3 Jonathan Rogers 2004-05-08 00:54:48 UTC
I forgot to mention that I didn't discover what was wrong or fix it. I simply read the mailing list, where Jeffrey F posted a patch:

<URL:http://sourceforge.net/mailarchive/forum.php?forum_id=9153>
Comment 4 Abhishek Amit (RETIRED) gentoo-dev 2004-05-08 02:07:21 UTC
Thanks for reporting this. There's just a few things I would change in the ebuild. First, die should have some descriptive error message("Failed to unpack sources", or "Failed to apply no-redirect patch"). Then, instead of giving the name of the file to unpack, you can just use ${A} (unpack ${A}||die "Failed to unpack sources"). That's not a real issue, but it just seems cleaner that way to me. Finally, I can't see the point of putting header-translation in /usr/share/yosucker, because from what I can tell, YoSucker will either look in /usr/share/conf or ~/.yosucker for the header-translation file, so just putting header-translation in /usr/share/yosucker doesn't accomplish anything as far as I can tell. Please correct me if I'm wrong. If you could just fix those things up, I'll commit the ebuild. Thanks again for reporting this so quickly.
Comment 5 Abhishek Amit (RETIRED) gentoo-dev 2004-05-08 15:14:05 UTC
I've added the no-redirect patch so that yosucker works. I'll leave this bug open to look at the /usr/share/yosucker idea. Thanks for reporting this.
Comment 6 Jonathan Rogers 2004-05-08 21:16:33 UTC
YoSucker looks for the file "header-translation" in the same directory as the config file it has chosen. This means that the file must exist in each user's ".yosucker" directory. If the file is installed in a location that doesn't change with each new version, there can be a symlink from the ".yosucker" directory. A much better solution would be for YoSucker to look for global config files in a central location like any well-behaved *nix program.
Comment 7 Jonathan Rogers 2004-05-08 21:31:54 UTC
Created attachment 31025 [details]
tweaked ebuild

unpack and epatch handle errors themselves, so the "die" calls were unnecessary
Comment 8 Jonathan Rogers 2004-05-10 12:28:34 UTC
It seems I was a little too hasty in trying to deal with the YoSucker login issue, since the patch may only be necessary or advisable for some users. It may not be the same for users of Yahoo in other places than the US.

I haven't investigated the problem or its solution carefully myself, but it is being discussed on the YoSucker list by those who do understand it better. Unfortunately, the Sourceforge archives seem to lag by a few days, so I can't provide a URL to the most relevant posts, but here is the project page:
<URL:http://sourceforge.net/projects/yosucker/>

The situation is atypical, since the patch in question isn't even of alpha quality. However, it seems absolutely necessary for many YoSucker users. Probably, the ebuild with the patch should remain masked in Portage so that anyone who knows about the issue can quickly emerge it, but it won't break things for people who don't have problems.
Comment 9 Joseph Booker 2004-09-18 16:13:28 UTC
YoSucker is already at version 59; someone mark this FIXED or something
Comment 10 Andrej Kacian (RETIRED) gentoo-dev 2004-09-23 02:43:18 UTC
Closing, as requested