Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 504068 - dev-python/pygobject:3 should RDEPEND on x11-libs/cairo
Summary: dev-python/pygobject:3 should RDEPEND on x11-libs/cairo
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-10 11:54 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2014-03-11 02:52 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2014-03-10 11:54:12 UTC
dev-python/pygobject:3 currently has unconditional DEPEND="x11-libs/cairo[glib]" and no run-time dependency on x11-libs/cairo.

Based on my testing of all ebuilds, the correct dependencies should be:
  In =dev-python/pygobject-3.2*:
    DEPEND="cairo? ( x11-libs/cairo )"
    RDEPEND="cairo? ( x11-libs/cairo )"
  In >=dev-python/pygobject-3.4:
    DEPEND="cairo? ( x11-libs/cairo[glib] )"
    RDEPEND="cairo? ( x11-libs/cairo )"
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2014-03-10 23:07:13 UTC
I think the unconditionnal DEPEND is here for unittests. But maybe that constraint was removed by now ?
Comment 2 Arfrever Frehtes Taifersar Arahesis 2014-03-11 01:36:34 UTC
All ebuilds of dev-python/pygobject:3 already set REQUIRED_USE="test? ( cairo )".
Comment 3 Alexandre Rostovtsev (RETIRED) gentoo-dev 2014-03-11 02:00:22 UTC
pygobject-3.3.x and 3.4.0 had a hard build-time dependency on cairo, even if tests were disabled.

This was a mistake that upstream fixed in 3.4.1, but I forgot to update our ebuilds, sorry :/
Comment 4 Alexandre Rostovtsev (RETIRED) gentoo-dev 2014-03-11 02:06:54 UTC
+  11 Mar 2014; Alexandre Rostovtsev <tetromino@gentoo.org>
+  pygobject-3.4.2-r1.ebuild, pygobject-3.8.3.ebuild, pygobject-3.10.2.ebuild:
+  Hard build-time dependency on cairo not needed in >=pygobject-3.4.1 (bug
+  #504068, thanks to Arfrever).
Comment 5 Arfrever Frehtes Taifersar Arahesis 2014-03-11 02:30:55 UTC
(In reply to Alexandre Rostovtsev from comment #4)

It is incomplete.

1. Installed files are linked against libcairo.so.2 from x11-libs/cairo:
$ scanelf -qF "%F: %n" $(qlist dev-python/pygobject-3 | sort) | grep libcairo
/usr/lib64/python2.6/site-packages/gi/_gi_cairo.so: libglib-2.0.so.0,libcairo.so.2,libpthread.so.0,libc.so.6
/usr/lib64/python2.7/site-packages/gi/_gi_cairo.so: libglib-2.0.so.0,libcairo.so.2,libpthread.so.0,libc.so.6
/usr/lib64/python3.1/site-packages/gi/_gi_cairo.so: libglib-2.0.so.0,libcairo.so.2,libpthread.so.0,libc.so.6
/usr/lib64/python3.2/site-packages/gi/_gi_cairo.cpython-32.so: libglib-2.0.so.0,libcairo.so.2,libpthread.so.0,libc.so.6
/usr/lib64/python3.3/site-packages/gi/_gi_cairo.cpython-33.so: libglib-2.0.so.0,libcairo.so.2,libpthread.so.0,libc.so.6
/usr/lib64/python3.4/site-packages/gi/_gi_cairo.cpython-34.so: libglib-2.0.so.0,libcairo.so.2,libpthread.so.0,libc.so.6

2. libcairo-gobject.so.2 (provided by x11-libs/cairo[glib]) is used at build time even with USE="cairo -test".
Comment 6 Alexandre Rostovtsev (RETIRED) gentoo-dev 2014-03-11 02:52:41 UTC
Good point.

+  11 Mar 2014; Alexandre Rostovtsev <tetromino@gentoo.org>
+  pygobject-3.2.2-r1.ebuild, pygobject-3.4.2-r1.ebuild, pygobject-3.8.3.ebuild,
+  pygobject-3.10.2.ebuild:
+  Further cairo dependency fixes (bug #504068, thanks to Arfrever).