Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 503876 - kernel 3.12 - regression in the handling of usbatm debug traces
Summary: kernel 3.12 - regression in the handling of usbatm debug traces
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL: https://lkml.org/lkml/2013/10/26/65
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-08 14:48 UTC by Eric F. GARIOUD
Modified: 2014-05-09 18:51 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric F. GARIOUD 2014-03-08 14:48:11 UTC
Having CONFIG_USB_ATM set and CONFIG_USB_DEBUG not set, syslogs are now overfed with kyriads of
 
<< usbatm_rx_process: xyzt callbacks suppressed >>
 
messages per minute.

Cf url & discussion on the gentoo-kernel mailing list.

Reproducible: Always
Comment 1 Eric F. GARIOUD 2014-05-09 18:51:12 UTC
Fixed as part of 3.12.19 thanks to Jiri Slabi.
-------------------------------------
commit ec44c106c1641a532faaed93a7d26d4b3e90cc25
Author: Joe Perches <joe@perches.com>
Date:   Sat Oct 26 20:41:53 2013 -0700

    printk: pr_debug_ratelimited: check state first to reduce "callbacks suppressed" messages
    
    pr_debug_ratelimited should be coded similarly to dev_dbg_ratelimited
    to reduce the "callbacks suppressed" messages.
    
    Add #include <linux/dynamic_debug.h> to printk.h. Unfortunately, this
    new #include must be after the prototype/declaration of function printk.
    
    It may be better to split out these _ratelimited declarations into
    a separate file one day.
    
    Any use of these pr_<foo>_ratelimited functions must also have another
    specific #include <ratelimited.h>.  Most users have this done indirectly
    via #include <linux/kernel.h>
    
    printk.h may not #include <linux/ratelimit.h> as it causes circular
    dependencies and compilation failures.
----------------------------------
commit 1b667c7507f5a34d4f4d2a18c63ebba0139a6d70
Author: Joe Perches <joe@perches.com>
Date:   Sat Oct 26 20:49:24 2013 -0700

    usbatm: Fix dynamic_debug / ratelimited atm_dbg and atm_rldbg macros
    
    Fix atm_dbg to use normal pr_debug not dynamic_pr_debug
    because dynamic_pr_debug may not be compiled in at all.