Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 503768 - app-editors/vim: Add support for specifying featureset
Summary: app-editors/vim: Add support for specifying featureset
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal enhancement with 1 vote (vote)
Assignee: Vim Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-07 19:05 UTC by Seán C McCord
Modified: 2017-07-29 20:34 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patched version of the latest vim ebuild (vim-7.4.169-patched.ebuild,11.88 KB, text/plain)
2014-03-07 19:05 UTC, Seán C McCord
Details
Patched version of the latest vim metadata.xml (metadata.xml,1022 bytes, text/xml)
2014-03-07 19:05 UTC, Seán C McCord
Details
USE_EXPAND description file (vim_features.desc,373 bytes, text/plain)
2014-03-07 19:06 UTC, Seán C McCord
Details
patch for ebuild (vim-7.4.169.ebuild.patch,1.11 KB, patch)
2014-03-07 21:05 UTC, Seán C McCord
Details | Diff
patch for metadata.xml (metadata.xml.patch,830 bytes, patch)
2014-03-07 21:06 UTC, Seán C McCord
Details | Diff
patch for ebuild (vim-7.4.169.ebuild.patch,1.11 KB, patch)
2014-03-07 21:19 UTC, Seán C McCord
Details | Diff
patch for metadata.xml (metadata.xml.patch,825 bytes, patch)
2014-03-07 21:20 UTC, Seán C McCord
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Seán C McCord 2014-03-07 19:05:11 UTC
Created attachment 371974 [details]
Patched version of the latest vim ebuild

The current ebuild has two feature-set options:  'tiny' and 'huge'.  This update enables selection of any particular feature sets, while maintaining backward compatibility with the existing ebuild (specifically, minimal always means 'tiny' and no specification always means 'huge').

This implements the feature set selection via USE_EXPAND vim_features (which corresponds to the --with-features configure switch).
Comment 1 Seán C McCord 2014-03-07 19:05:41 UTC
Created attachment 371976 [details]
Patched version of the latest vim metadata.xml
Comment 2 Seán C McCord 2014-03-07 19:06:21 UTC
Created attachment 371980 [details]
USE_EXPAND description file
Comment 3 Tim Harder gentoo-dev 2014-03-07 20:26:53 UTC
Please attach patches for changed files, especially ebuilds.

With that said, I'm not convinced we need to support this level of granularity.
Comment 4 Seán C McCord 2014-03-07 21:05:48 UTC
Created attachment 371996 [details, diff]
patch for ebuild
Comment 5 Seán C McCord 2014-03-07 21:06:10 UTC
Created attachment 371998 [details, diff]
patch for metadata.xml
Comment 6 Seán C McCord 2014-03-07 21:10:22 UTC
The request is to accommodate an issue from CoreOS dev wherein there is a desire to have the small feature-set (which contains, for instance, visual mode) in order to keep the installed size down.  Rather than maintain a separate ebuild, it seemed more effective to simply allow users to explicitly declare their desired feature-set as a USE flag.
Comment 7 Seán C McCord 2014-03-07 21:15:14 UTC
That was poorly-worded, sorry.

In short, we're looking for a way to select a feature-set between 'tiny' (which is configured with the 'minimal' USE flag) and 'huge' (which is configured otherwise).  In this case, 'small' was chosen as optimal, but rather than adding random basic use flags, it makes more sense to simply expose the option directly.
Comment 8 Seán C McCord 2014-03-07 21:19:56 UTC
Created attachment 372000 [details, diff]
patch for ebuild

Fix reference:  large -> big
Comment 9 Seán C McCord 2014-03-07 21:20:31 UTC
Created attachment 372002 [details, diff]
patch for metadata.xml

fix references large -> big
Comment 10 Patrice Clement gentoo-dev 2017-07-29 20:34:32 UTC
After much debate on IRC, we decided not to implement this feature. If you do want to compile vim with a special set of features, go check out the EXTRA_ECONF variable and make sure to pass it to emerge at compile-time.