Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 503616 - =dev-python/doit-0.23.0 fails tests - ValueError: Attempted relative import in non-package
Summary: =dev-python/doit-0.23.0 fails tests - ValueError: Attempted relative import i...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ben de Groot (RETIRED)
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks:
 
Reported: 2014-03-06 12:55 UTC by eroen
Modified: 2014-03-21 07:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,14.89 KB, text/plain)
2014-03-06 12:55 UTC, eroen
Details
cvs diff -u (doit.patch,6.53 KB, patch)
2014-03-19 08:33 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description eroen 2014-03-06 12:55:37 UTC
Created attachment 371862 [details]
build.log

* python2_7: running distutils-r1_run_phase python_test
 * Test test_action.py passed under python2.7
 * Test test_cmd_auto.py passed under python2.7
 * Test test_cmd_base.py passed under python2.7
 * Test test_cmd_clean.py passed under python2.7
 * Test test_cmd_dumpdb.py passed under python2.7
Traceback (most recent call last):
  File "tests/test_cmd_forget.py", line 8, in <module>
    from .conftest import tasks_sample
ValueError: Attempted relative import in non-package
 * ERROR: dev-python/doit-0.23.0::gentoo failed (test phase):
 *   Test tests/test_cmd_forget.py failed under python2.7
Comment 1 eroen 2014-03-06 12:56:03 UTC
eroen@falcon ~ $ emerge --info '=dev-python/doit-0.23.0::gentoo'
Portage 2.2.8-r1 (default/linux/amd64/13.0, gcc-4.8.2, glibc-2.18-r1, 3.12.5e0-falcon0+ x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-3.12.5e0-falcon0+-x86_64-Intel-R-_Core-TM-2_Quad_CPU_@_2.40GHz-with-gentoo-2.2
KiB Mem:     4037884 total,    828928 free
KiB Swap:    8388604 total,   7813152 free
Timestamp of tree: Wed, 05 Mar 2014 17:45:01 +0000
ld GNU ld (GNU Binutils) 2.24
distcc 3.1 x86_64-pc-linux-gnu [disabled]
ccache version 3.1.9 [disabled]
app-shells/bash:          4.2_p45-r1
dev-java/java-config:     2.2.0
dev-lang/python:          2.7.6, 3.2.5-r3, 3.3.4, 3.4.0_rc1
dev-util/ccache:          3.1.9-r3
dev-util/cmake:           2.8.12.2
dev-util/pkgconfig:       0.28
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.12.4
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.9.6-r3, 1.11.6, 1.12.6, 1.13.4, 1.14.1
sys-devel/binutils:       2.24-r2
sys-devel/gcc:            4.5.4, 4.6.4, 4.7.3-r1, 4.8.2
sys-devel/gcc-config:     1.8
sys-devel/libtool:        2.4.2
sys-devel/make:           4.0-r1
sys-kernel/linux-headers: 3.13 (virtual/os-headers)
sys-libs/glibc:           2.18-r1
Repositories: gentoo gamerlay eroen
ACCEPT_KEYWORDS="amd64 ~amd64 ~x86"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=core2 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/themes/oxygen-gtk/gtk-2.0"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=core2 -O2 -pipe"
DISTDIR="/var/distfiles"
EMERGE_DEFAULT_OPTS="--jobs 3 --nospinner --quiet-build --verbose-conflicts --with-bdeps=y --binpkg-respect-use y"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS=""
LANG="en_GB.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j4"
PKGDIR="/var/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/gamerlay /var/lib/layman/eroen"
SYNC="rsync://mirrors.eu.kernel.org/gentoo-portage/"
USE="X a52 aac aacs accessibility acl adns alsa amd64 ao berkdb bluray bs2b bzip2 cairo calendar canberra caps cdda cdio cdparanoia cdr cli
corefonts cracklib crypt css cue cups curl cxx dbus dia dirac djvu dmapi dri dts dvd dvdnav dvi ebook eigen exif faac fam fbcondecor ffmpeg
fftw fits flac fontconfig fortran fuse g3dvl gcrypt gd gdbm gif gimp git gmp gnutls gold gstreamer hdri highlight iconv icu id3tag idn imagemagick inotify iptc ipv6 jpeg jpeg2k kde kvm lcms lensfun libnotify loop-aes lqr lzma lzo mad man matroska midi mikmod mkv mms mmx mmxext mng mod modplug modules mp3 mp4 mpeg mpeg2 mpeg4 mpeg4pt2 mplayer mtp multilib musepack ncurses netlink nfs nls nouveau nptl ocr offensive ogg openal opencl openexr opengl opengtl openmp openvg optimization osmesa pam pango pcre pdf png pnm portaudio postscript qalculate qemu qt3support qt4 rar raw rdesktop readline real rtmp samba scanner schroedinger security session smp sndfile socks5 speex spice sse sse2 sse3 ssl ssse3 strong-optimization svg tbb tcpd theora threads tiff timidity tls truetype udev uml unicode usb usbredir v4l v4l2 vdpau virtualbox vnc
vorbis wacom wavpack webp wmf x264 xattr xcb xcomposite xetex xfs xft xine xinerama xorg xps xrandr xv xvid xvmc zlib" ABI_X86="32 64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex
cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CURL_SSL="openssl" DRACUT_MODULES="biosdevname caps crypt crypt-gpg dash dmraid lvm mdraid syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf
superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64 pc qemu" INPUT_DEVICES="evdev keyboard mouse synaptics wacom" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="nlpsolver presenter-console presenter-minimizer" LINGUAS="en en_US en_GB nb no nb_NO" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_2 python3_3" RUBY_TARGETS="ruby20" SANE_BACKENDS="net plustek pnm" USERLAND="GNU" VIDEO_CARDS="nouveau nvidia vesa" XFCE_PLUGINS="menu" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
USE_PYTHON="2.7 3.2 3.3"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
eroen@falcon ~ $ emerge -pqv '=dev-python/doit-0.23.0::gentoo'
[ebuild  N    ] dev-python/doit-0.23.0  USE="{test}" PYTHON_TARGETS="python2_7 python3_2 python3_3 -pypy2_0 -python2_6"
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2014-03-19 08:33:29 UTC
Created attachment 373002 [details, diff]
cvs diff -u

This test phase is mine from mid last year.  While I was practised with test suites then, I am now even more so.  The test phase using a loop to run each test was never the right solution.  It only made for no error output which was simply deceiving.  It also created the local import issue and has no place in this suite.

The tests of the previous 0.20.0 were unprepared for py3. I was in fact de-railed by running them in the source using 2to3 before finally observing they ran just right without its use run from the ebuild via 'python runtests.py'.  Despite my best efforts, the test phase of -0.20.0 was flawed.  They were designed to run from pytest and indeed they do.  The test phase is completely re-done as it ought to have been.

The bug I filed back then provided some hints but mostly the extent of my confusion.  It appears pytest itself is the source of some failures due to its 'management or setting' of a tmp dir.  This is not unknown.  There are some further commented notes in the patch.  pypy appears to lack an inbuilt sqlite3. You could consider dropping pypy support of leave as is and have it skipped in the test phase.  If really keen, you can code in skipping those tests in the pypy run!

It appears the dep six was also missed in the bump,  Add pytest for test phase makes for;

+DEPEND="test? ( dev-python/pytest[${PYTHON_USEDEP}] )"
+RDEPEND="dev-python/pyinotify[${PYTHON_USEDEP}]
+       dev-python/six[${PYTHON_USEDEP}]"

thoughts?
Comment 3 Ben de Groot (RETIRED) gentoo-dev 2014-03-21 06:17:25 UTC
Personally I don't care about tests, as I've come across too many upstreams who are careless with them. So please feel free to fix this any way you want.
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2014-03-21 07:02:08 UTC
You might care to re-visit:
        dodoc -r doc
        docompress -x /usr/share/doc/${PF}/doc

and substitute it with a USE doc and python style doc build and install.  This reflects what was done long ago in the former 'python distutils eclass era'.  For now this bug is about the testsuite which I didn't manage to figure almost a year ago.

*doit-0.23.0-r1 (21 Mar 2014)

  21 Mar 2014; Ian Delaney <idella4@gentoo.org> +doit-0.23.0-r1.ebuild,
  -files/doit-0.16.1-setup.py-encoding.patch:
  revbump; update deps, rm old patch, fix test phase, fixes Bug 503616 by eroen