Hi! Torsmo is a system monitor that sits in the corner of your desktop. It's very simple, customizable and it renders only text on the desktop (and percentagebars if you want it to ;) and the only lib it uses is Xlib. Torsmo can show various information about your system and it's peripherals, including: * kernel version * uptime * network interface information * memory and swap usage * hostname * machine, i686 for example * system name, Linux for example * Temperatures from i2c-sensors
Created attachment 30931 [details] torsmo-0.14.ebuild
Created attachment 30932 [details] torsmo-0.14.ebuild metadata.xml
Created attachment 30933 [details] torsmo-0.14.ebuild ChangeLog
Created attachment 30934 [details] torsmo-0.14.ebuild Manifest
Created attachment 30935 [details] torsmo-0.14.ebuild digest-torsmo-0.14
I'm a mewbie to ebuild submissions, i'm trying to folow the rules, please correct-me if i'm doing something wrong. Tank's
You're doing pretty well: Good points: All in all a pretty good ebuild. Your src_compile and src_install functions are perfect. The pkg_postinst function is fantastic. It is better that the previous one I was just about to commit before I found your bug report. Big flaws: Only you can only assign the variables once (SRC_URI). Multiple assignment overwites the previous one. S="${S} blah blah balh" is allowed if required. Dependancies - ok I'm a bit retentive about these but x11 needs to exist for the program to run. As for all the other dependancies I've added - a lot of people would call pedantic (until they get bug reports saying xyz is a dependancy). Don't use USE flags unless it changes some way the program compiles. Could be better: In the case of the SRC_URI a simple mirror statement allows for all. When using a mirror statement use RESTRICT="nomirror" so gentoo's mirrors don't mirror these files when they are suffiecienly mirrored anyway. Avoid using variables in human readable sections of the ebuild like DESCRIPTION, einfo/ewarn and HOMEPAGE. Its handy to copy/paste homepage into a browser so ${PN} is realy an inconvience. As far as files to place here - realy only a ebuild is required and maybe the longdescription out of the metadata.xml file. Of course any patches needed will also need to be here. Keep up the good submissions.
Thank's a lot to point my mistakes, i'm still have a lot to learn. I'm a bit confused using the ebuilds found in portage as example, because not all ebuilds seems to follow the rules, then is easy to do some errors. I'm sorry about my massive use variables is the human readable sections, i just did it because it seems easy (about lazy) to bump the ebuild to new versions. I really appreciate your tips, it's very helpful to improve my next ebuils. (forgive my grammar, english is not my language).
No problem - you've done well. Keep it up. I see your point about not all ebuilds following the rules. Some are not written down. Adding more rules is the easy bit however there are lots already and tools need to be made to help developers enforce the rules.
