Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 503430 - x11-plugins/bitlbee-steam - add USE=debug
Summary: x11-plugins/bitlbee-steam - add USE=debug
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All All
: Normal normal
Assignee: Julian Ospald
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-04 17:33 UTC by James Geboski (jgeboski)
Modified: 2014-03-05 13:16 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James Geboski (jgeboski) 2014-03-04 17:33:46 UTC
The bitlbee-steam plugin has an optional debug feature which should be enabled via the 'debug' USE flag. This feature is disabled or enabled via arguments to the autoconf script: --disable-debug or --enable-debug. If enabled, the plugin will output information to stdout (like the rest of bitlbee) if BITLBEE_DEBUG or BITLBEE_DEBUG_STEAM are defined in the working environment.

James
Comment 1 Julian Ospald 2014-03-04 21:11:55 UTC
I will not add this to the live ebuild though, since it needs patching... unless I feel bored enough to hack up something that upstream will merge
Comment 2 James Geboski (jgeboski) 2014-03-04 22:46:10 UTC
I am the upstream developer, what needs patching?
Comment 3 Julian Ospald 2014-03-04 22:50:29 UTC
(In reply to James Geboski (jgeboski) from comment #2)
> I am the upstream developer, what needs patching?

The debug switch changes CFLAGS. In gentoo we do not want that, although I can understand why the developer may want it that way.

The simplest solution would be to just rm the CFLAGS manipulation like I did
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/x11-plugins/bitlbee-steam/files/bitlbee-steam-1.0.0-debug.patch?view=markup

The most convenient solution would be to add something like "--enable-minimal-flags" which would then disable CFLAGS manipulation even if "--enable-debug" is set. So gentoo would unconditionally do "--enable-minimal-flags".
Comment 4 James Geboski (jgeboski) 2014-03-05 03:23:20 UTC
I pushed a patch onto master which enables the usage of '--enable-minimal-flags'.

https://github.com/jgeboski/bitlbee-steam/commit/870dca1
Comment 5 Julian Ospald 2014-03-05 13:16:20 UTC
+  05 Mar 2014; Julian Ospald <hasufell@gentoo.org> bitlbee-steam-9999.ebuild:
+  add debug USE flag to live ebuild