503336 – cmake-utils.eclass: cmake-utils_src_make missing quote for arguments

Bug 503336 - cmake-utils.eclass: cmake-utils_src_make missing quote for arguments

Summary: cmake-utils.eclass: cmake-utils_src_make missing quote for arguments

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Gentoo KDE team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2014-03-03 17:46 UTC by Julian Ospald
Modified:	2014-03-09 15:51 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Julian Ospald 2014-03-03 17:46:00 UTC

when CXX has whitespace, then
  cmake-utils_src_compile LD="$(tc-getCXX)"
will fail horribly, while
  emake LD="$(tc-getCXX)"
works just fine

It seems there is a quote missing in cmake-utils_src_make:

--- a/eclass/cmake-utils.eclass
+++ b/eclass/cmake-utils.eclass
@@ -592,7 +592,7 @@
 	_check_build_dir
 	pushd "${BUILD_DIR}" >/dev/null
 
-	${CMAKE_MAKEFILE_GENERATOR}_src_make $@
+	${CMAKE_MAKEFILE_GENERATOR}_src_make "$@"
 
 	popd >/dev/null
 }

Comment 1 Julian Ospald 2014-03-09 00:16:57 UTC

seems trivial enough to me, so I will fix this in 2 weeks if there are no objections

Comment 2 Michael Palimaka (kensington) gentoo-dev

2014-03-09 15:51:43 UTC

Thanks, fixed in CVS.

+  09 Mar 2014; Michael Palimaka <kensington@gentoo.org> cmake-utils.eclass:
+  Add missing quotes wrt bug #503336.