Hi, I upgraded sys-libs/readline to sys-libs/readline-6.3 and now sys-fs/lvm2 doesn't build anymore: lvm.c: In function ‘lvm_shell’: lvm.c:188:38: error: ‘CPPFunction’ undeclared (first use in this function) rl_attempted_completion_function = (CPPFunction *) _completion; ^ lvm.c:188:38: note: each undeclared identifier is reported only once for each function it appears in lvm.c:188:51: error: expected expression before ‘)’ token rl_attempted_completion_function = (CPPFunction *) _completion; ^ lvm.c: At top level: make[1]: Entering directory '/var/tmp/portage/sys-fs/lvm2-2.02.105-r2/work/LVM2.2.02.105/scripts' lvm.c:124:15: warning: ‘_completion’ defined but not used [-Wunused-function] static char **_completion(const char *text, int start_pos, ^ ../make.tmpl:362: recipe for target 'lvm.o' failed make[1]: *** [lvm.o] Error 1 When I downgrade to =sys-libs/readline-6.2_p5-r1 everything works again. Looks like there is something wrong with the new sys-libs/readline. There are other bugs like bug 503106 or bug 503180. Maybe we should mask sys-libs/readline-6.3? Reproducible: Always
Created attachment 371588 [details] build.log
OK, it is not a bug in sys-libs/readline-6.3 (but maybe we should create a tracker bug for other packages). Here's a fix for LVM2: https://gitorious.org/buildroot/buildroot/commit/fb36a82a745e93afc92bb5aff29daea8daecb6d3
We'll address this upstream, but will probably do it in a way that maintains compatibility.
Here's another patch which will keep backward compatibility: http://cross-lfs.org/~kb0iic/LVM2.2.02.105-readline-1.patch
Upstream fixed the problem: https://git.fedorahosted.org/cgit/lvm2.git/commit/tools/lvm.c?id=216c57eed72fee52e99bb5d014c9de535e631f58
should be all set now in the tree; thanks for the report! Commit message: Add fix from upstream for building w/readline-6.3 http://sources.gentoo.org/sys-fs/lvm2/files/lvm2-2.02.105-readline-6.3.patch?rev=1.1 http://sources.gentoo.org/sys-fs/lvm2/lvm2-2.02.105-r2.ebuild?r1=1.5&r2=1.6
