Bug 502716 – dev-libs/leveldb-1.15.0: stabilization request

• Status: RESOLVED OBSOLETE
• Product: Gentoo Linux

[Description Paweł Hajdan, Jr. (RETIRED) 2014-02-27 05:14:56 UTC]

Is it OK to stabilize =dev-libs/leveldb-1.15.0 ?
If so, please CC all arches which have stable keywords
for older versions of this package.

[Comment 1 Luke-Jr 2014-03-22 05:33:42 UTC]

1.14 and 1.15 break backward compatibility, so downgrading to 1.13 or older will corrupt databases. What has been done to ensure users are aware of this?

[Comment 2 Johan Bergström 2014-03-23 22:37:16 UTC]

@luke-jr: I'd consider pkg_postinst einfo, but that's about it. Patrick?

[Comment 3 Greg Turner 2014-03-25 03:10:53 UTC]

Created attachment 373462 [details, diff]
leveldb-1.15-configure.patch

Add a patch like leveldb-1.9-configure.patch from gx86 that applies to 1.15.

[Comment 4 Greg Turner 2014-03-25 03:13:01 UTC]

Created attachment 373464 [details, diff]
leveldb-1.15-memenv-shared.patch

If leveldb consumers are going to link their own shared libraries against the memenv.o embedded in /usr/$(libdir)/libmemenv.a, then we'll need to link it in a manner consistent with the rest of the .o files, like a shared library; this adds a rule to make that happen to the Makefile.

[Comment 5 Greg Turner 2014-03-25 03:14:11 UTC]

Created attachment 373466 [details, diff]
leveldb-1.15.0-r1.ebuild

Updated version of leveldb ebuild that manages to screw things up in several fewer ways :)

[Comment 6 Greg Turner 2014-03-25 03:17:05 UTC]

Created attachment 373468 [details, diff]
leveldb-1.15.0-r1.ebuild

(try2: snafu'ed first upload attempt)

[Comment 7 Greg Turner 2014-03-25 03:19:51 UTC]

My changes, to dev-libs/leveldb-1.15.0, for convenience, expressed as a diff from the current gx86 ebuild to the one uploaded:

--- /usr/portage/dev-libs/leveldb/leveldb-1.15.0.ebuild 2014-03-24 18:49:06.117083678 -0700
+++ /usr/local/portage/gmt/dev-libs/leveldb/leveldb-1.15.0-r1.ebuild    2014-03-24 19:58:50.194351984 -0700
@@ -1,6 +1,6 @@
-# Copyright 1999-2013 Gentoo Foundation
+# Copyright 1999-2014 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/dev-libs/leveldb/leveldb-1.15.0.ebuild,v 1.1 2013/12/16 05:04:15 patrick Exp $
+# $Header: $
 
 EAPI=4
 
@@ -13,7 +13,7 @@ SRC_URI="http://${PN}.googlecode.com/fil
 LICENSE="BSD"
 SLOT="0"
 KEYWORDS="~amd64 ~arm ~x86 ~amd64-linux ~x86-linux"
-IUSE="+snappy static-libs +tcmalloc"
+IUSE="-c++0x +snappy static-libs +tcmalloc"
 
 DEPEND="tcmalloc? ( dev-util/google-perftools )
        snappy? (
@@ -23,7 +23,10 @@ DEPEND="tcmalloc? ( dev-util/google-perf
 RDEPEND="${DEPEND}"
 
 src_prepare() {
-       epatch "${FILESDIR}"/${PN}-1.9.0-configure.patch
+       # avoid automagic behavior
+       epatch "${FILESDIR}"/${P}-configure.patch
+       # build memenv in shared libs compat way
+       epatch "${FILESDIR}"/${P}-memenv-shared.patch
 }
 
 src_configure() {
@@ -37,6 +40,7 @@ src_configure() {
        *) TARGET_OS="Linux";;
        esac
        export USE_SNAPPY=$(usex snappy)
+       export USE_CXX0X=$(usex c++0x)
        export USE_TCMALLOC=no
 }

[Comment 8 Greg Turner 2014-03-25 03:31:11 UTC]

Created attachment 373470 [details]
metadata.xml

adds c++0x useflag metadata

[Comment 9 SpanKY 2015-03-06 09:09:16 UTC]

Comment on attachment 373462 [details, diff]
leveldb-1.15-configure.patch

this bug is about stabilization.  please file feature requests as new bugs.

[Comment 10 Pacho Ramos 2015-05-31 08:54:10 UTC]

Please open one bug per issue (this is obsolete too as probably a newer version should be the candidate now)