Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 501712 - sys-apps/portage: ebuild.sh outputs QA notice when automake is called from _automake_version
Summary: sys-apps/portage: ebuild.sh outputs QA notice when automake is called from _a...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
: 502154 503284 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-02-18 19:40 UTC by Mike Gilbert
Modified: 2018-04-15 10:29 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Add _automake_version to the whitelist (0001-Add-_automake_version-to-the-autotools-whitelist.patch,928 bytes, patch)
2014-02-22 19:00 UTC, Mike Gilbert
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Gilbert gentoo-dev 2014-02-18 19:40:43 UTC
* QA Notice: 'automake' called by _automake_version: app-shells/dash-0.5.7.4
 * Use autotools.eclass instead of calling 'automake' directly.

I think this problem was introduced in version 1.160 of autotools.eclass.

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/autotools.eclass?r1=1.159&r2=1.160
Comment 1 Mike Gilbert gentoo-dev 2014-02-18 20:01:03 UTC
It looks like ebuild.sh has a hard-coded whitelist of functions where automake may be called.
Comment 2 Mike Gilbert gentoo-dev 2014-02-22 18:48:03 UTC
*** Bug 502154 has been marked as a duplicate of this bug. ***
Comment 3 Mike Gilbert gentoo-dev 2014-02-22 19:00:08 UTC
Created attachment 371084 [details, diff]
Add _automake_version to the whitelist

Here's the obvious fix.

It would be nice if we did not have to hard-code that list in ebuild.sh, however.
Comment 4 Sergei Trofimovich (RETIRED) gentoo-dev 2014-03-01 12:35:41 UTC
I was impatient and pushed it as:

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/autotools.eclass?r1=1.160&r2=1.161

Maybe it's worth keeping single function-wrapper that exempts from warnings?

Like 'blessed-autocall() { "@" }' and stop maintaining that large list?
Otherwise it's a bit too tied to portage version.
Comment 5 Ben Kohler gentoo-dev 2014-03-03 04:30:21 UTC
*** Bug 503284 has been marked as a duplicate of this bug. ***
Comment 6 SpanKY gentoo-dev 2014-11-17 02:28:16 UTC
(In reply to Sergei Trofimovich from comment #4)

unfortunately your change broke the function entirely.  it needed to parse the output, but the wrapper function swallows all the output (by design).
Comment 7 Sergei Trofimovich (RETIRED) gentoo-dev 2014-11-23 17:08:18 UTC
(In reply to SpanKY from comment #6)
> (In reply to Sergei Trofimovich from comment #4)
> 
> unfortunately your change broke the function entirely.  it needed to parse
> the output, but the wrapper function swallows all the output (by design).

Ugh, apologies for breakage.

Thanks for fixing it!