Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 501370 - xfce-base/xfce4-session: Add alock support for xflock4
Summary: xfce-base/xfce4-session: Add alock support for xflock4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-15 10:28 UTC by Jesús Guerrero Botella (RETIRED)
Modified: 2014-03-05 12:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to add alock support to xflock4 (xflock4-alock_support.diff,361 bytes, patch)
2014-02-15 10:29 UTC, Jesús Guerrero Botella (RETIRED)
Details | Diff
Patched 4.10.0-r1 ebuild (xfce4-session-4.10.0-r1.ebuild,1.86 KB, text/plain)
2014-02-15 10:30 UTC, Jesús Guerrero Botella (RETIRED)
Details
Patched 4.10.1 ebuild (xfce4-session-4.10.1.ebuild,1.65 KB, text/plain)
2014-02-15 10:30 UTC, Jesús Guerrero Botella (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jesús Guerrero Botella (RETIRED) gentoo-dev 2014-02-15 10:28:25 UTC
Xfce uses a little shell snippet to guess what your screen locker is. The rest of the xfce menus, buttons, applets, etc. call that script to lock the screen.

The script has support for a number of screen lockers, but it's missing support for alock. I just added it as a fallback option and it works fine. It shouldn't interfere with any of the others, since alock would be used only as a last resort. It just requires pam, which should be ok I guess.

Reproducible: Always

Actual Results:  
If your only screen locker is alock, then the xfce applets and menu options to lock the screen don't work, despite the fact that they are clickable.

Expected Results:  
These should work with all the screen lockers, if possible.
Comment 1 Jesús Guerrero Botella (RETIRED) gentoo-dev 2014-02-15 10:29:08 UTC
Created attachment 370464 [details, diff]
Patch to add alock support to xflock4
Comment 2 Jesús Guerrero Botella (RETIRED) gentoo-dev 2014-02-15 10:30:00 UTC
Created attachment 370466 [details]
Patched 4.10.0-r1 ebuild
Comment 3 Jesús Guerrero Botella (RETIRED) gentoo-dev 2014-02-15 10:30:23 UTC
Created attachment 370468 [details]
Patched 4.10.1 ebuild
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2014-02-15 11:15:10 UTC
Report this to http://bugzilla.xfce.org/ and add the link here to See Also: field

We don't have *any* patches in Portage for Xfce that haven't been submitted to upstream, and if they reject, we also drop.

Thanks.
Comment 5 Jesús Guerrero Botella (RETIRED) gentoo-dev 2014-02-15 11:25:15 UTC
I did a few days ago. I haven't received any answer though.

https://bugzilla.xfce.org/show_bug.cgi?id=10679
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2014-02-15 11:29:04 UTC
(In reply to Jesús Guerrero from comment #5)
> I did a few days ago. I haven't received any answer though.
> 
> https://bugzilla.xfce.org/show_bug.cgi?id=10679

That's OK, important part is that we need to have link to upstream bugzilla in the patch header for the record, so Gentoo's Xfce doesn't resemble the unmaintainable spagetti eg. Ubuntu's version is ;-)
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2014-03-05 11:50:49 UTC
added to xfce4-session-4.10.1-r1.   let's hope upstream will accept it, otherwise I can't guarantee 4.12+ will have it
Comment 8 Samuli Suominen (RETIRED) gentoo-dev 2014-03-05 11:53:30 UTC
had to make the dependency x11-misc/alock[pam] due to the -auth pam argument used.
no way to make the locker work with and without pam at the same time?
Comment 9 Jesús Guerrero Botella (RETIRED) gentoo-dev 2014-03-05 12:20:53 UTC
I guess the sanest we can get is

alock -auth passwd || alock -auth pam

Or maybe reversing it, it depends on how alock will behave on a system without pam and which one you prefer over the other auth method. I haven't a pam-less system, so I can't test it.