Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 500742 - dev-python/qrcode should depend on virtual/python-imaging
Summary: dev-python/qrcode should depend on virtual/python-imaging
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-09 07:42 UTC by Florian Faber
Modified: 2015-11-11 10:12 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Faber 2014-02-09 07:42:22 UTC
qrcode can produce PNG output, however the ebuild has no dependency on a python image library such as pillow.
Comment 1 dwfreed 2014-02-09 11:25:16 UTC
From a quick look at the source (particularly setup.py, and some of the readme), qrcode doesn't actually need any imaging library (though you can't export images without one), so a dependency on python-imaging or pillow would be superfluous.  With the current setup.py, you could do 'pip install qrcode', and pip would not attempt to install python-imaging or pillow.  I think the better solution here would be an elog in pkg_postinst suggesting to install python-imaging or pillow if it is not already installed.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-02-09 17:30:03 UTC
A quick look at the ebuild may give a tip:

# optional deps:
# - dev-python/lxml for svg backend
# - virtual/pil for PIL backend

I was aware of the deps. However, we don't have any sane way of expressing optional deps, so they are kindly waiting for a new EAPI in a comment.
Comment 3 Justin Lecher (RETIRED) gentoo-dev 2015-11-11 10:12:49 UTC
commit 9e276c984be1309437d2356c63752ac96d14bb57
Author: Justin Lecher <jlec@gentoo.org>
Date:   Wed Nov 11 11:12:26 2015 +0100
    
    dev-python/qrcode: Use optfeature to point to optional deps
    
    Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=500742
    
    Package-Manager: portage-2.2.23
    Signed-off-by: Justin Lecher <jlec@gentoo.org>
    
    https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9e276c984be1309437d2356c63752ac96d14bb57