Bug 500538 – x11-misc/gtk-theme-config - A tool to configure GTK theme colors

• Status: UNCONFIRMED
• Product: Gentoo Linux

[Description Leif J Burrow 2014-02-06 17:16:40 UTC]

Created attachment 369712 [details]
gtk-theme-config-9999.ebuild

This is an ebuild for gtk-theme-config, an application for configuring one's gtk2/3 colors without requiring Gnome.

[Comment 1 Jeroen Roovers (RETIRED) 2014-02-06 17:26:41 UTC]

Comment on attachment 369712 [details]
gtk-theme-config-9999.ebuild

># Copyright 2014 Gentoo Foundation
># Distributed under the terms of the GNU General Public License v2
># $Header: $
>
>EAPI=4

Why not 5?

>DB_VER="4.8"
>
>inherit db-use eutils git-2 versionator

I think git-r3 is preferred.

>DESCRIPTION="A tool to configure GTK theme colors."
>HOMEPAGE="https://github.com/satya164/gtk-theme-config"
>EGIT_PROJECT='gtk2-theme-config'
>EGIT_REPO_URI="https://github.com/satya164/gtk-theme-config.git"

Looks like a live ebuild. No releases yet?

>SRC_URI=""

No need to set that for a live ebuild.

>LICENSE="GPL-3"
>SLOT="0"
>KEYWORDS=""
>IUSE=""

Empty IUSE need not be set.

>DEPEND="
>sys-devel/gcc

You should not explicitly depend on a compiler - it's in the "system" set.

>>=dev-libs/glib-2.0
>>=x11-libs/gtk+-3.0
>>=dev-lang/vala-0.16.0
>"
>
>RDEPEND="
>>=x11-libs/gtk+-3.0
>"

RDEPEND should probably include DEPEND.

>DEPEND="${DEPEND}

You're setting DEPEND twice here.

>>=app-shells/bash-4.1
>"

Maybe you should also add a comment on why this bash dependency is required.

>src_install() {
>emake DESTDIR="${D}" install

That's the "default".

>dodoc AUTHORS LICENSE README.md
>}

LICENSE should not be installed, but referred to in the LICENSE variable.

If you set DOCS=( ... ) and remove the entire src_install(), these docs get installed automatically.