Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 500460 - =dev-python/astropy-0.3 has unneeded blockers
Summary: =dev-python/astropy-0.3 has unneeded blockers
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Astronomy project
URL:
Whiteboard:
Keywords: EBUILD, PATCH
Depends on:
Blocks:
 
Reported: 2014-02-06 03:44 UTC by Joseph Booker
Modified: 2014-02-10 08:13 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Non-blocking ebuild for astropy (astropy-0.3-r1.ebuild,1.87 KB, text/plain)
2014-02-06 03:44 UTC, Joseph Booker
Details
eselect ebuild for pyfits/astropy tools (eselect-pyfits-tools-0.1.ebuild,934 bytes, text/plain)
2014-02-06 03:45 UTC, Joseph Booker
Details
eselect module for fitscheck (fitscheck.eselect-0.1,431 bytes, text/plain)
2014-02-06 03:45 UTC, Joseph Booker
Details
eselect module for fitsdiff (fitsdiff.eselect-0.1,426 bytes, text/plain)
2014-02-06 03:46 UTC, Joseph Booker
Details
Updated pyfits ebuild (pyfits-3.2.ebuild,1.37 KB, text/plain)
2014-02-06 03:46 UTC, Joseph Booker
Details
Non-blocking ebuild for pywcs (pywcs-1.11-r2.ebuild,1.02 KB, text/plain)
2014-02-06 03:46 UTC, Joseph Booker
Details
Non-blocking ebuild for vo (vo-0.8-r2.ebuild,1.08 KB, text/plain)
2014-02-06 03:47 UTC, Joseph Booker
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Booker 2014-02-06 03:44:01 UTC
When astropy started, it included the pyfits, pywcs, and vo packages.
As discussed in https://github.com/astropy/astropy/pull/1493 , the legacy API (aka, calling `import pyfits`) was removed in astropy 0.3.

With the legacy option removed, astropy no longer conflicts with any of the other python package. This bug report is an attempt to fix this.

Furthermore, these packages are still having releases seperate from their version in astropy, so it is conceivable that the user may want to use these packages instead of the versions in astropy.

Reproducible: Always

Steps to Reproduce:
1. emerge astropy
2. Unsuccessfully use a python script that imports pyfits, pywcs, or vo
3. emerge pyfits, pywcs, or vo
Actual Results:  
The emerge fails due to each package blocking astropy (and visa versa)

Expected Results:  
One is able to co-install packages with seperate python modules.

I've attached some ebuilds and an eselect module to deal with the one conflict: both pyfits and astropy include fitsdiff and fitscheck.

Additionally, dependancies on virtual/pyfits or virtual/pywcs should probably be reconsidered. If packages need to be able to do 'import pyfits' or 'import pywcs', then only astropy-0.2 or pyfits/pywcs can satisify that.

Also, pywcs doesn't need pyfits according to their website, and pyfits has a version bump.
Comment 1 Joseph Booker 2014-02-06 03:44:56 UTC
Created attachment 369674 [details]
Non-blocking ebuild for astropy
Comment 2 Joseph Booker 2014-02-06 03:45:25 UTC
Created attachment 369676 [details]
eselect ebuild for pyfits/astropy tools
Comment 3 Joseph Booker 2014-02-06 03:45:59 UTC
Created attachment 369678 [details]
eselect module for fitscheck
Comment 4 Joseph Booker 2014-02-06 03:46:14 UTC
Created attachment 369680 [details]
eselect module for fitsdiff
Comment 5 Joseph Booker 2014-02-06 03:46:31 UTC
Created attachment 369682 [details]
Updated pyfits ebuild
Comment 6 Joseph Booker 2014-02-06 03:46:54 UTC
Created attachment 369684 [details]
Non-blocking ebuild for pywcs
Comment 7 Joseph Booker 2014-02-06 03:47:15 UTC
Created attachment 369686 [details]
Non-blocking ebuild for vo
Comment 8 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2014-02-06 07:31:37 UTC
Thank you for filing this bug and providing a patch; assigned to the maintainers.
Comment 9 Sébastien Fabbro (RETIRED) gentoo-dev 2014-02-06 15:06:34 UTC
yesterday i committed unblocking to astropy, vo, and pywcs, and changed all virtual while checking reverse dependencies please re-sync your tree. 

i don't think we need the eselect-pyfits given we'll be removing <astropy-0.3 soon, but i'll see for the fits{check,diff} tools, since there is still a file conflict.
Comment 10 Joseph Booker 2014-02-06 19:17:05 UTC
(In reply to Sébastien Fabbro from comment #9)
> yesterday i committed unblocking to astropy, vo, and pywcs, and changed all
> virtual while checking reverse dependencies please re-sync your tree. 
> 
> i don't think we need the eselect-pyfits given we'll be removing
> <astropy-0.3 soon, but i'll see for the fits{check,diff} tools, since there
> is still a file conflict.

Thanks, sorry for missing that.

Do you mean that we don't need the virtual/pyfits since <astropy-0.3 will be removed soon?

I think there's three ways to deal with the fits{check,diff} tools:
1. Install both, use eselect to switch between them.
2. Make them optional (like with a 'tools' USE flag), and block on the other having that flag set.
3. Rename the tools in one, but not the other.
4. Not install the tools in one

Given that the files are basically identical (at least, in pyfits-3.2 and astropy-0.3), I'm not sure what the motivication would be for changing between them, except that you'd probably expect to have fits{check,diff} if either one is installed.
Comment 11 Sébastien Fabbro (RETIRED) gentoo-dev 2014-02-06 19:48:04 UTC
(In reply to Joseph Booker from comment #10)
 
> Do you mean that we don't need the virtual/pyfits since <astropy-0.3 will be
> removed soon?

yes


> 3. Rename the tools in one, but not the other.

chosen solution: renamed in pyfits-*

+  06 Feb 2014; Sébastien Fabbro <bicatali@gentoo.org>
+  -files/pyfits-3.0.8-debundle_zlib.patch, -pyfits-3.1.2.ebuild,
+  pyfits-2.4.0.ebuild, pyfits-3.2.ebuild:
+  Renamed conflicting binaries to *-pyfits, removed old, thanks Joseph Booker,
+  bug # 500460
+


thanks for your input
Comment 12 Ian Delaney (RETIRED) gentoo-dev 2014-02-08 03:52:16 UTC
how about;

+	>=dev-python/stsci-distutils-0.3[${PYTHON_USEDEP}]
+	>=dev-python/d2to1-0.2.5[${PYTHON_USEDEP}]"

from
 setup_requires=['d2to1>=0.2.5', 'stsci.distutils>=0.3'],
from
portage/dev-python/pyfits-3.2/work/pyfits-3.2/setup.py
Comment 13 Sébastien Fabbro (RETIRED) gentoo-dev 2014-02-10 08:13:55 UTC
+  10 Feb 2014; Sébastien Fabbro <bicatali@gentoo.org> pyfits-3.2.ebuild:
+  Fixed minimum version of dependencies
+