Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 500430 - kde-base/kdelibs-4.12.2: Please include kdeconnect solid-backend.patch for phone battery reporting
Summary: kde-base/kdelibs-4.12.2: Please include kdeconnect solid-backend.patch for ph...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo KDE team
URL: http://albertvaka.wordpress.com/2013/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-05 20:57 UTC by Andreas Sturmlechner
Modified: 2014-11-27 12:05 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
kdeconnect-solid-backend.patch (kdelibs-4.11.2-kdeconnect-solid-backend.patch,29.79 KB, patch)
2014-02-05 20:57 UTC, Andreas Sturmlechner
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2014-02-05 20:57:46 UTC
Created attachment 369650 [details, diff]
kdeconnect-solid-backend.patch

"For battery reporting to work you will also need to apply this patch to kdelibs"

So far I've been using this via epatch_user. Applying it enables build of the solid phonepower backend unconditionally.

1) apply it anyway?
2) patch USE conditionally?
3) change the CMakeLists.txt part to make it a build option?
Comment 1 Michael Palimaka (kensington) gentoo-dev 2014-02-25 19:03:25 UTC
Is there plans for this to be integrated upstream? We usually prefer to stick to upstream where possible, especially for non-bugfix stuff such as this.
Comment 2 Andreas Sturmlechner gentoo-dev 2014-03-09 19:39:34 UTC
Well, I can't point you to any statement, but it sure isn't yet in kdelibs upstream because of the same reason, that it is non-bugfix sfuff. So far they have not ported it to kde frameworks 5.
Comment 3 Ian Whyman (thev00d00) (RETIRED) gentoo-dev 2014-04-02 07:37:19 UTC
+1 for including this from me.
Comment 4 Johannes Huber (RETIRED) gentoo-dev 2014-04-04 08:53:31 UTC
(In reply to Michael Palimaka (kensington) from comment #1)
> Is there plans for this to be integrated upstream? We usually prefer to
> stick to upstream where possible, especially for non-bugfix stuff such as
> this.

+ 1 from me to upstream this

(In reply to Ian Whyman (thev00d00) from comment #3)
> +1 for including this from me.

We decided in a former kde herd meeting not to include feature patches.

@Andreas Please use git.reviewboard.kde.org and link the review request back here, if it is accepted upstream we can backport it
Comment 5 Michael Palimaka (kensington) gentoo-dev 2014-11-27 12:05:35 UTC
Regrettably the situation does not appear to have changed so the patch is still unsuitable for us to carry in the main tree.