Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 500266 - sci-calculators/speedcrunch-0.11: respect LINGUAS, install svg icon
Summary: sci-calculators/speedcrunch-0.11: respect LINGUAS, install svg icon
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-02-04 11:43 UTC by Nikoli
Modified: 2014-06-14 20:06 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch, works for me (speedcrunch-0.11.ebuild.patch,1.14 KB, patch)
2014-02-04 11:43 UTC, Nikoli
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikoli 2014-02-04 11:43:16 UTC
Created attachment 369522 [details, diff]
patch, works for me

Building with LINGUAS="" makes bin much smaller:
-1528392 /usr/bin/speedcrunch
+987720  /usr/bin/speedcrunch

It works fine, selecting language too.
Comment 1 Justin Lecher (RETIRED) gentoo-dev 2014-02-04 12:01:50 UTC
+*speedcrunch-0.11-r1 (04 Feb 2014)
+
+  04 Feb 2014; Justin Lecher <jlec@gentoo.org> +speedcrunch-0.11-r1.ebuild,
+  -speedcrunch-0.11.ebuild:
+  handle langs, #500266 thanks Nikoli for the patch; use ninja
+
Comment 2 Nikoli 2014-02-04 14:09:24 UTC
Why you removed 'ar_JO tr_TR uz_UZ' from PLOCALES? Removing them means force enabling, instead they should be added to profiles/desc/linguas.desc

Also why you force usage of ninja, is something broken without it? For me it builds and works fine without ninja.
Comment 3 Justin Lecher (RETIRED) gentoo-dev 2014-02-04 15:43:07 UTC
(In reply to Nikoli from comment #2)
> Why you removed 'ar_JO tr_TR uz_UZ' from PLOCALES? Removing them means force
> enabling, instead they should be added to profiles/desc/linguas.desc
> 

Are those locales official ones? How can this be found out? ANd if so please open another bug for this.


> Also why you force usage of ninja, is something broken without it? For me it
> builds and works fine without ninja.

ninja builds are faster then make builds faster. That doesn't matter for speedcrunch I will try to move all cmake packages to ninja if it works.

For speedcrunch:

make  7-8   s
ninja 6-6.5 s
Comment 4 Sergey Popov gentoo-dev 2014-02-05 12:43:47 UTC
(In reply to Justin Lecher from comment #3)
> (In reply to Nikoli from comment #2)
> > Why you removed 'ar_JO tr_TR uz_UZ' from PLOCALES? Removing them means force
> > enabling, instead they should be added to profiles/desc/linguas.desc
> > 
> 
> Are those locales official ones? How can this be found out? ANd if so please
> open another bug for this.

Please clarify what 'official locale' means, cause i added some locales that used in packages i maintain in linguas.desc(after googling what concrete language/country they are represent) and neither i nor QA guys have any problems with this.
Comment 5 Justin Lecher (RETIRED) gentoo-dev 2014-02-05 13:01:10 UTC
(In reply to Sergey Popov from comment #4)
> Please clarify what 'official locale' means, cause i added some locales that
> used in packages i maintain in linguas.desc(after googling what concrete
> language/country they are represent) and neither i nor QA guys have any
> problems with this.

That was basically my question, are there official locale? Or can anybody invent a combination?
Comment 6 Sergey Popov gentoo-dev 2014-05-28 11:15:00 UTC
(In reply to Justin Lecher from comment #5)
> (In reply to Sergey Popov from comment #4)
> > Please clarify what 'official locale' means, cause i added some locales that
> > used in packages i maintain in linguas.desc(after googling what concrete
> > language/country they are represent) and neither i nor QA guys have any
> > problems with this.
> 
> That was basically my question, are there official locale? Or can anybody
> invent a combination?

I think this site[1] can help with finding existing locales and their proper names

[1] - http://lh.2xlibre.net/
Comment 7 Justin Lecher (RETIRED) gentoo-dev 2014-06-14 20:06:31 UTC
+*speedcrunch-0.11-r2 (14 Jun 2014)
+
+  14 Jun 2014; Justin Lecher <jlec@gentoo.org> +speedcrunch-0.11-r2.ebuild,
+  metadata.xml:
+  Add missing locales, #500266
+