Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 500056 - repoman: ebuild.notadded warning should be fatal when committing
Summary: repoman: ebuild.notadded warning should be fatal when committing
Status: RESOLVED WONTFIX
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-02 08:42 UTC by Pacho Ramos
Modified: 2022-07-12 03:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2014-02-02 08:42:31 UTC
I don't see the reasons for making "ebuild.notadded" warning not to be fatal since, anyway, people won't be able to commit later:
RepoMan scours the neighborhood...
>>> Creating Manifest for /home/pacho/gentoo-x86/x11-themes/light-themes
  ebuild.badheader              1
   x11-themes/light-themes/light-themes-0.1.93-r3.ebuild: Invalid Gentoo Copyright on line: 1
  ebuild.notadded               1
   x11-themes/light-themes/light-themes-0.1.93-r3.ebuild

Note: use --include-dev (-d) to check dependencies for 'dev' profiles

!!! The following files are in your local tree but are not added to the master
!!! tree. Please remove them from the local tree or add them to the master tree.
    ./light-themes-0.1.93-r3.ebuild

Thanks!
Comment 1 SpanKY gentoo-dev 2014-02-03 14:54:59 UTC
it should only be fatal when using `repoman commit`.  just doing checking (like `repoman full`) shouldn't fail.
Comment 2 Pacho Ramos gentoo-dev 2014-02-03 19:52:39 UTC
In that case I guess it's not a big problem since it will die anyway. I was thinking a bit more on getting the "red" error at "repoman full" stage (sometimes I miss it as some packages have lots of other "soft" (yellow) warnings due things like -j1 usage and so... Then, if you prefer to get this closed as wontfix, no problem :)
Comment 3 SpanKY gentoo-dev 2014-02-05 07:57:49 UTC
(In reply to Pacho Ramos from comment #2)

having repoman fail when you try to commit w/ebuild.notadded is reasonable as it's very very unlikely that's what the dev wants.  on the other hand, having it fail when you're just doing a check is very very unlikely what the dev wants.

i think implementing this behavior makes sense.  now someone just needs to do it :).
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-12 03:18:34 UTC
repoman support has been removed per bug 835013.

Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.