If mozjs-17 is installed, cinnamon-1.8.8.1-r1 fails with: cinnamon-global.c:1242:25: error: too many arguments to function ‘gjs_log_exception’ Solution can be found in this commit: https://github.com/leigh123linux/Cinnamon/commit/914d7da8baea24b1b31e2bcf982d12996f86694a src/cinnamon-global.c @@ -1237,14 +1237,11 @@ enum 0, &target_object)) { - char *message; - gjs_log_exception(context, - &message); + gjs_log_exception(context); g_set_error(error, G_IO_ERROR, G_IO_ERROR_FAILED, - "%s", message ? message : "(unknown)"); - g_free(message); + "Unable to import %s", target_object_script); goto out_error; } However this breaks compile for older js... Regards: Dw.
So, the thing basically requires mozjs-17 and fails with it at the same time? Awesome :).
+*cinnamon-1.8.8.1-r2 (26 Feb 2014) + + 26 Feb 2014; Michał Górny <mgorny@gentoo.org> +cinnamon-1.8.8.1-r2.ebuild, + +files/cinnamon-1.8.8.1-mozjs17.patch: + Fix build failure with mozjs17, bug #499980. Committed with silent 'we do not care' agreement from gnome team :).
Well not exactly silent ;) Still need to clarify maintainership on this though. Thanks for fixing it.