Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 499420 - media-gfx/valentina - open source fashion design software
Summary: media-gfx/valentina - open source fashion design software
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Miroslav Šulc
URL: http://valentina-project.blogspot.ru/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-27 06:22 UTC by renato gallo
Modified: 2016-02-23 09:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
valentina sources (valentina-0.2.1.tar.gz,321.62 KB, application/gzip)
2014-01-27 06:49 UTC, renato gallo
Details
valentina-0.3.1.ebuild (valentina-0.3.1.ebuild,1.19 KB, text/plain)
2015-05-14 18:18 UTC, Karl-Johan Karlsson
Details
0.3.1-disable-ccache.patch (0.3.1-disable-ccache.patch,761 bytes, patch)
2015-05-14 18:19 UTC, Karl-Johan Karlsson
Details | Diff
valentina-0.3.1.ebuild v2 (valentina-0.3.1.ebuild,1.22 KB, text/plain)
2015-05-14 22:12 UTC, Karl-Johan Karlsson
Details
0.3.1-use-portage-split-debug.patch (0.3.1-use-portage-split-debug.patch,3.16 KB, patch)
2015-05-14 22:44 UTC, Karl-Johan Karlsson
Details | Diff
valentina-0.3.1.ebuild v3 (valentina-0.3.1.ebuild,1.24 KB, text/plain)
2015-05-14 22:45 UTC, Karl-Johan Karlsson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description renato gallo 2014-01-27 06:22:51 UTC
http://libregraphicsworld.org/blog/entry/introducing-valentina-free-fashion-design-software


New interesting software to make clothing needs a gentoo ebuild.... who wants to help ?
Comment 1 renato gallo 2014-01-27 06:39:25 UTC
ccache g++ -pipe -O1 -O2 -Wall -W -D_REENTRANT -DQT_NO_DEBUG_OUTPUT -DDATADIR=\"/usr/share\" -DPKGDATADIR=\"\" -DQT_NO_DEBUG -DQT_SVG_LIB -DQT_XML_LIB -DQT_GUI_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtXml -I/usr/include/qt4/QtSvg -I/usr/include/qt4 -Imoc -Iuic -x c++-header -c src/stable.h -o obj/valentina.gch/c++
src/stable.h:48:21: fatal error: QtWidgets: No such file or directory
 #include <QtWidgets>
                     ^
compilation terminated.
Makefile:546: recipe for target 'obj/valentina.gch/c++' failed
make: *** [obj/valentina.gch/c++] Error 1
Comment 2 renato gallo 2014-01-27 06:49:24 UTC
Created attachment 368854 [details]
valentina sources
Comment 3 renato gallo 2014-01-27 06:50:51 UTC
 locate qt|grep -i widgets
/usr/include/qt4/Qt/q3widgetstack.h
/usr/include/qt4/Qt3Support/Q3WidgetStack
/usr/include/qt4/Qt3Support/q3widgetstack.h
/usr/include/qt4/QtGui/QTableWidgetSelectionRange
/usr/include/qt4/QtGui/QWidgetSet
/usr/lib32/qt4/plugins/accessible/libqtaccessiblewidgets.so
/usr/lib32/qt4/plugins/designer/libphononwidgets.so
/usr/lib64/qt4/plugins/accessible/libqtaccessiblewidgets.so
/usr/lib64/qt4/plugins/designer/libphononwidgets.so
/usr/lib64/qt4/plugins/designer/libqt3supportwidgets.so
/usr/portage/sci-mathematics/qtoctave/files/qtoctave-0.10.1-build-widgetserver.patch
locate Qt|grep -i widgets
/usr/include/qt4/Qt/q3widgetstack.h
/usr/include/qt4/Qt3Support/Q3WidgetStack
/usr/include/qt4/Qt3Support/q3widgetstack.h
/usr/include/qt4/QtGui/QTableWidgetSelectionRange
/usr/include/qt4/QtGui/QWidgetSet
Comment 5 Karl-Johan Karlsson 2015-05-14 18:18:34 UTC
Created attachment 403264 [details]
valentina-0.3.1.ebuild

Proposed ebuild for media-gfx/valentina-0.3.1.

Upstream forces use of ccache, which I remove with a patch.

"make install" does not support DESTDIR, so do all installation manually.
Comment 6 Karl-Johan Karlsson 2015-05-14 18:19:26 UTC
Created attachment 403266 [details, diff]
0.3.1-disable-ccache.patch

Patch for the qmake project file, removing the forced use of ccache.
Comment 7 Karl-Johan Karlsson 2015-05-14 22:12:18 UTC
Created attachment 403272 [details]
valentina-0.3.1.ebuild v2

Install the menu icon.

TODO: The build system does its own split debug thing:

   objcopy --only-keep-debug bin/valentina bin/valentina.dbg &&
   objcopy --strip-debug bin/valentina &&
   objcopy --add-gnu-debuglink=bin/valentina.dbg bin/valentina

and the same for libvpropertyexplorer.so and libqmuparser.so. Integrate this into Portage's split debug handling.
Comment 8 Karl-Johan Karlsson 2015-05-14 22:44:50 UTC
Created attachment 403274 [details, diff]
0.3.1-use-portage-split-debug.patch
Comment 9 Karl-Johan Karlsson 2015-05-14 22:45:50 UTC
Created attachment 403276 [details]
valentina-0.3.1.ebuild v3

Remove custom split-debug handling, so Portage does it for us.
Comment 10 Roman 2015-05-16 14:12:27 UTC
(In reply to Karl-Johan Karlsson from comment #5)
> Created attachment 403264 [details]
> valentina-0.3.1.ebuild
> 
> Proposed ebuild for media-gfx/valentina-0.3.1.
> 
> Upstream forces use of ccache, which I remove with a patch.
> 
> "make install" does not support DESTDIR, so do all installation manually.

Do you know that it is possible run qmake like this?

Example:

qmake PREFIX=/usr PREFIX_LIB=/usr/lib ../Valentina.pro -r
Comment 11 Karl-Johan Karlsson 2015-05-16 14:34:25 UTC
(In reply to Roman from comment #10)
> qmake PREFIX=/usr PREFIX_LIB=/usr/lib ../Valentina.pro -r

I don't understand how that would help. It is my understanding that PREFIX says where the files will end up on the live system, and that is already correct in my ebuilds, but that the DESTDIR option to "make install" says where they will be staged in order to create the installable image, i.e. DESTDIR ends up being something like /var/tmp/portage/media-gfx/valentina-0.3.1/image/. The files only reside there temporarily, and no trace of that directory should remain in the installed files.
Comment 12 Roman 2015-05-16 17:35:34 UTC
(In reply to Karl-Johan Karlsson from comment #11)
> (In reply to Roman from comment #10)
> > qmake PREFIX=/usr PREFIX_LIB=/usr/lib ../Valentina.pro -r
> 
> I don't understand how that would help. It is my understanding that PREFIX
> says where the files will end up on the live system, and that is already
> correct in my ebuilds, but that the DESTDIR option to "make install" says
> where they will be staged in order to create the installable image, i.e.
> DESTDIR ends up being something like
> /var/tmp/portage/media-gfx/valentina-0.3.1/image/. The files only reside
> there temporarily, and no trace of that directory should remain in the
> installed files.

Ok, now i see. Actually qmake support DESTDIR option, but i don't understand how it works.

All other patches i ported. In next major release (0.4.0) they will be available. 

Example:
qmake ../Valentina.pro -r CONFIG+=noStripDebugSymbols CONFIG+=no_ccache
Comment 13 Miroslav Šulc gentoo-dev 2016-02-18 18:11:16 UTC
valentina-0.4.2 and valentina-9999 are now in the tree. i did not use the split-debug patch as idk whether it is still needed.

please test, comment, send patches. thanks.

i'll leave this bug open for a while so you can comment the ebuilds here with regard to the previous patches.
Comment 14 Miroslav Šulc gentoo-dev 2016-02-19 11:51:01 UTC
i did some improvements of the ebuilds with help from roman telezhynskyi (the author)

there are still two qa warnings related to insecure runpath that he is working on atm...
Comment 15 mrbit 2016-02-20 15:34:51 UTC
please change in the ebuils of valentina:

 S=${WORKDIR}/dismine-${PN}-44d43351cb59
   with 
 S=${WORKDIR}/dismine-${PN}-de569135bf2c


thanks ;)
Comment 16 Miroslav Šulc gentoo-dev 2016-02-20 16:03:16 UTC
(In reply to mrbit from comment #15)
> please change in the ebuils of valentina:
> 
>  S=${WORKDIR}/dismine-${PN}-44d43351cb59
>    with 
>  S=${WORKDIR}/dismine-${PN}-de569135bf2c
> 
> 
> thanks ;)

i can see only dismine-valentina-44d43351cb59 in the zip file. also downloaded the fresh zip from upstream and it has the same path. do you have some issue with the versioned ebuild?
Comment 17 mrbit 2016-02-20 20:02:31 UTC
(In reply to Miroslav Šulc from comment #16)
> (In reply to mrbit from comment #15)
> > please change in the ebuils of valentina:
> > 
> >  S=${WORKDIR}/dismine-${PN}-44d43351cb59
> >    with 
> >  S=${WORKDIR}/dismine-${PN}-de569135bf2c
> > 
> > 
> > thanks ;)
> 
> i can see only dismine-valentina-44d43351cb59 in the zip file. also
> downloaded the fresh zip from upstream and it has the same path. do you have
> some issue with the versioned ebuild?


oops sorry :

 valentina-0.4.2-r3.ebuild
Comment 18 Miroslav Šulc gentoo-dev 2016-02-20 20:44:55 UTC
(In reply to mrbit from comment #17)
> oops sorry :
> 
>  valentina-0.4.2-r3.ebuild

that one compiles fine for me.
Comment 19 mrbit 2016-02-20 23:07:36 UTC
(In reply to Miroslav Šulc from comment #18)
> (In reply to mrbit from comment #17)
> > oops sorry :
> > 
> >  valentina-0.4.2-r3.ebuild
> 
> that one compiles fine for me.

strange .. mhummm.!!
OK ,delete default.zip and re-download new file default.zip ,now compila
sorry :(
Comment 20 Miroslav Šulc gentoo-dev 2016-02-23 09:09:09 UTC
closing this bug. if you find any issue, please open new bug and assign it to me.